You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/05/31 20:06:57 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6507: Consolidate panic propagation into RecordBatchReceiverStream

alamb commented on code in PR #6507:
URL: https://github.com/apache/arrow-datafusion/pull/6507#discussion_r1212238341


##########
datafusion/core/src/physical_plan/coalesce_partitions.rs:
##########
@@ -270,4 +231,19 @@ mod tests {
 
         Ok(())
     }
+
+    #[tokio::test]

Review Comment:
   This is the new test from @nvartolomei 



##########
datafusion/core/src/physical_plan/coalesce_partitions.rs:
##########
@@ -183,32 +168,6 @@ impl ExecutionPlan for CoalescePartitionsExec {
     }
 }
 
-struct MergeStream {

Review Comment:
   I basically taught `RecordBatchReceiverStream` how to propagate panics and then updated `CoalescePartitionsExec` to use it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org