You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:34:36 UTC

[GitHub] [thrift] RandyAbernethy commented on pull request #2151: THRIFT-5186: Rewrite address resolution in T{Nonblocking,}ServerSocket [REVIEW WANTED]

RandyAbernethy commented on pull request #2151:
URL: https://github.com/apache/thrift/pull/2151#issuecomment-641296711


   With a diff that big I could have easily missed something but sometimes code needs an overhaul. Code changes looked clean to me. If CI is passing: +1
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org