You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/08/08 04:26:18 UTC
Review Request 13401: Fixed handling of executor history on slaves.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13401/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Fixed handling of executor history on slaves.
This resolves https://issues.apache.org/jira/browse/MESOS-616.
Diffs
-----
src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
Diff: https://reviews.apache.org/r/13401/diff/
Testing
-------
make check
Thanks,
Brenden Matthews
Re: Review Request 13401: Fixed handling of executor history on slaves.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13401/#review25183
-----------------------------------------------------------
Ship it!
Brenden, can you commit this after adding the TODO that Ben mentioned? Thanks
- Vinod Kone
On Aug. 8, 2013, 2:57 a.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13401/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 2:57 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed handling of executor history on slaves.
>
> This resolves https://issues.apache.org/jira/browse/MESOS-616.
>
> Review: https://reviews.apache.org/r/13401
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
>
> Diff: https://reviews.apache.org/r/13401/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13401: Fixed handling of executor history on slaves.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13401/#review25187
-----------------------------------------------------------
Hey Brenden, do you mind committing the *previous* diff (with our Ship Its) with an added TODO?
We can take on the cache changes in a separate review. :)
- Ben Mahler
On Aug. 14, 2013, 9:28 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13401/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 9:28 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-616
> https://issues.apache.org/jira/browse/MESOS-616
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed handling of executor history on slaves.
>
> The list of retired (completed) frameworks is now a stout cache rather
> than a boost circular buffer. There are now key iterator accessors for
> the cache class, and a removal member.
>
> This resolves https://issues.apache.org/jira/browse/MESOS-616.
>
> Review: https://reviews.apache.org/r/13401
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 653507c5f1293acb929d2ffa33738fd830541c84
> src/slave/http.cpp 073d0923febf697dec2a9bbfa6e3b243bcab7316
> src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce
> src/slave/slave.cpp cf9f2923fe0e854d457519d700acc951279e1bba
>
> Diff: https://reviews.apache.org/r/13401/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13401: Fixed handling of executor history on slaves.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13401/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 10:01 p.m.)
Review request for mesos.
Bugs: MESOS-616
https://issues.apache.org/jira/browse/MESOS-616
Repository: mesos-git
Description (updated)
-------
Fixed handling of executor history on slaves.
This resolves https://issues.apache.org/jira/browse/MESOS-616.
Review: https://reviews.apache.org/r/13401
Diffs (updated)
-----
src/slave/slave.cpp cf9f2923fe0e854d457519d700acc951279e1bba
Diff: https://reviews.apache.org/r/13401/diff/
Testing
-------
make check
Thanks,
Brenden Matthews
Re: Review Request 13401: Fixed handling of executor history on slaves.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13401/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 9:28 p.m.)
Review request for mesos.
Changes
-------
Updated as per Ben's comments.
Bugs: MESOS-616
https://issues.apache.org/jira/browse/MESOS-616
Repository: mesos-git
Description (updated)
-------
Fixed handling of executor history on slaves.
The list of retired (completed) frameworks is now a stout cache rather
than a boost circular buffer. There are now key iterator accessors for
the cache class, and a removal member.
This resolves https://issues.apache.org/jira/browse/MESOS-616.
Review: https://reviews.apache.org/r/13401
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 653507c5f1293acb929d2ffa33738fd830541c84
src/slave/http.cpp 073d0923febf697dec2a9bbfa6e3b243bcab7316
src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce
src/slave/slave.cpp cf9f2923fe0e854d457519d700acc951279e1bba
Diff: https://reviews.apache.org/r/13401/diff/
Testing
-------
make check
Thanks,
Brenden Matthews
Re: Review Request 13401: Fixed handling of executor history on slaves.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13401/#review25172
-----------------------------------------------------------
Ship it!
Can you also add the bug ID to the review?
src/slave/slave.cpp
<https://reviews.apache.org/r/13401/#comment49438>
Instead of iterating, we should use stout/cache.hpp to store them instead of a circular buffer (now that we want to do a quick lookup). But you will need to add a removal operation to cache.
Either of the following are fine with me:
size_type erase(const Key& key);
// Allows you to get and remove in one call.
Option<Value> remove(const Key& key);
Feel free to simply punt and leave a TODO for later though! Just commenting on this as a note for posterity.
- Ben Mahler
On Aug. 8, 2013, 2:57 a.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13401/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 2:57 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed handling of executor history on slaves.
>
> This resolves https://issues.apache.org/jira/browse/MESOS-616.
>
> Review: https://reviews.apache.org/r/13401
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
>
> Diff: https://reviews.apache.org/r/13401/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13401: Fixed handling of executor history on slaves.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13401/
-----------------------------------------------------------
(Updated Aug. 8, 2013, 2:57 a.m.)
Review request for mesos.
Changes
-------
Messed up the first patch.
Repository: mesos-git
Description (updated)
-------
Fixed handling of executor history on slaves.
This resolves https://issues.apache.org/jira/browse/MESOS-616.
Review: https://reviews.apache.org/r/13401
Diffs (updated)
-----
src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
Diff: https://reviews.apache.org/r/13401/diff/
Testing
-------
make check
Thanks,
Brenden Matthews