You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/09 16:16:49 UTC
[GitHub] [camel-kafka-connector] oscerd opened a new issue #439: Define a default naming for converters, transforms and aggregation packages
oscerd opened a new issue #439:
URL: https://github.com/apache/camel-kafka-connector/issues/439
We need to list what we currently have in our codebase and move our converters, transforms and aggregation in a default named package.
In this way, we could search for a specific package and automatically generated/lists the available converters, transforms and AggregationStrategies defined for each converters (if any).
In this way we should be able to add more information for end users.
My proposal is to use:
- org.apache.camel.kafkaconnector.<connector_name>.converters
- org.apache.camel.kafkaconnector.<connector_name>.transforms
- org.apache.camel.kafkaconnector.<connector_name>.strategies
Actually we are still on time because we have a little amount of this stuff, but in future this would a pain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd closed issue #439: Define a default naming for converters, transforms and aggregation packages
Posted by GitBox <gi...@apache.org>.
oscerd closed issue #439:
URL: https://github.com/apache/camel-kafka-connector/issues/439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #439: Define a default naming for converters, transforms and aggregation packages
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #439:
URL: https://github.com/apache/camel-kafka-connector/issues/439#issuecomment-690903256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #439: Define a default naming for converters, transforms and aggregation packages
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #439:
URL: https://github.com/apache/camel-kafka-connector/issues/439#issuecomment-690903256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #439: Define a default naming for converters, transforms and aggregation packages
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #439:
URL: https://github.com/apache/camel-kafka-connector/issues/439#issuecomment-690903256
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd closed issue #439: Define a default naming for converters, transforms and aggregation packages
Posted by GitBox <gi...@apache.org>.
oscerd closed issue #439:
URL: https://github.com/apache/camel-kafka-connector/issues/439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #439: Define a default naming for converters, transforms and aggregation packages
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #439:
URL: https://github.com/apache/camel-kafka-connector/issues/439#issuecomment-690026099
Yeah, it makes sense, I'll merge the PR and then rework on package naming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on issue #439: Define a default naming for converters, transforms and aggregation packages
Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #439:
URL: https://github.com/apache/camel-kafka-connector/issues/439#issuecomment-690025483
> My proposal is to use:
>
> * org.apache.camel.kafkaconnector.<connector_name>.converters
>
> * org.apache.camel.kafkaconnector.<connector_name>.transforms
>
> * org.apache.camel.kafkaconnector.<connector_name>.strategies
+1. I think this looks straight to the point and consistent. My only comment would be regarding `transforms`. Wouldn't it be more precise to use `transformers`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd closed issue #439: Define a default naming for converters, transforms and aggregation packages
Posted by GitBox <gi...@apache.org>.
oscerd closed issue #439:
URL: https://github.com/apache/camel-kafka-connector/issues/439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org