You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2023/10/10 09:00:38 UTC
[PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
yaooqinn opened a new pull request, #43307:
URL: https://github.com/apache/spark/pull/43307
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR introduces selectable animation for Spark SQL Plan Node On UI, which lights up the selected node and its linked nodes and edges.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Better UX for SQL plan visualization and debugging. Especially for large queries, users can now concentrate on the current node and its nearest neighbors to get a better understanding of node lineage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, let's see the video.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
https://github.com/apache/spark/assets/8326978/f5ba884c-acce-46b8-8568-3ead55c91d4f
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #43307:
URL: https://github.com/apache/spark/pull/43307#discussion_r1352987532
##########
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js:
##########
@@ -269,3 +270,47 @@ function togglePlanViz() { // eslint-disable-line no-unused-vars
planVizContainer().style("display", "none");
}
}
+
+/*
+ * Light up the selected node and its linked nodes and edges.
+ */
+function setupSelectionForSparkPlanNode(g) {
+ const linkedNodes = new Map();
+ const linkedEdges = new Map();
+
+ g.edges().forEach(function (e) {
+ const edge = g.edge(e);
+ const from = g.node(e.v);
+ const to = g.node(e.w);
+ collectLinks(linkedNodes, from.id, to.id);
+ collectLinks(linkedNodes, to.id, from.id);
+ collectLinks(linkedEdges, from.id, edge.arrowheadId);
+ collectLinks(linkedEdges, to.id, edge.arrowheadId);
+ });
+
+ linkedNodes.forEach((linkedNodes, selectNode) => {
+ d3.select("#" + selectNode).on("click", () => {
+ planVizContainer()
+ .selectAll("*")
+ .classed("selected", false)
+ .classed("linked", false);
+ d3.select("#" + selectNode + " rect").classed("selected", true);
+ linkedNodes.forEach((linkedNode) => {
+ d3.select("#" + linkedNode + " rect").classed("linked", true);
+ });
+ linkedEdges.get(selectNode).forEach((linkedEdge) => {
+ const arrowHead = d3.select("#" + linkedEdge + " path");
+ arrowHead.classed("linked", true);
+ const arrowShaft = $(arrowHead.node()).parents("g.edgePath").children("path");
Review Comment:
The head and shaft are not at the same level, in order to get their common ancestor with the d3 selection API, we need to hard code like
```javascript
d3.select(d3.select(arrowHead.node().parentNode).node().parentNode).select("path")
```
It appears not future-proofing. The suitable way is using edge ID, but it seems not supported by both graphdot-lib and dagre-d3 yet. In this scenario, jQuery appears to be a suitable option based on our typical usage in UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43307:
URL: https://github.com/apache/spark/pull/43307#discussion_r1352676387
##########
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js:
##########
@@ -269,3 +270,47 @@ function togglePlanViz() { // eslint-disable-line no-unused-vars
planVizContainer().style("display", "none");
}
}
+
+/*
+ * Light up the selected node and its linked nodes and edges.
+ */
+function setupSelectionForSparkPlanNode(g) {
+ const linkedNodes = new Map();
+ const linkedEdges = new Map();
+
+ g.edges().forEach(function (e) {
+ const edge = g.edge(e);
+ const from = g.node(e.v);
+ const to = g.node(e.w);
+ collectLinks(linkedNodes, from.id, to.id);
+ collectLinks(linkedNodes, to.id, from.id);
+ collectLinks(linkedEdges, from.id, edge.arrowheadId);
+ collectLinks(linkedEdges, to.id, edge.arrowheadId);
+ });
+
+ linkedNodes.forEach((linkedNodes, selectNode) => {
+ d3.select("#" + selectNode).on("click", () => {
+ planVizContainer()
+ .selectAll("*")
+ .classed("selected", false)
+ .classed("linked", false);
+ d3.select("#" + selectNode + " rect").classed("selected", true);
+ linkedNodes.forEach((linkedNode) => {
+ d3.select("#" + linkedNode + " rect").classed("linked", true);
+ });
+ linkedEdges.get(selectNode).forEach((linkedEdge) => {
+ const arrowHead = d3.select("#" + linkedEdge + " path");
+ arrowHead.classed("linked", true);
+ const arrowShaft = $(arrowHead.node()).parents("g.edgePath").children("path");
Review Comment:
How about using d3's api uniformly?
Like `d3.select(arrowHead.node().parentNode).select("path");` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #43307:
URL: https://github.com/apache/spark/pull/43307#discussion_r1352810926
##########
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js:
##########
@@ -269,3 +270,47 @@ function togglePlanViz() { // eslint-disable-line no-unused-vars
planVizContainer().style("display", "none");
}
}
+
+/*
+ * Light up the selected node and its linked nodes and edges.
+ */
+function setupSelectionForSparkPlanNode(g) {
+ const linkedNodes = new Map();
+ const linkedEdges = new Map();
+
+ g.edges().forEach(function (e) {
+ const edge = g.edge(e);
+ const from = g.node(e.v);
+ const to = g.node(e.w);
+ collectLinks(linkedNodes, from.id, to.id);
+ collectLinks(linkedNodes, to.id, from.id);
+ collectLinks(linkedEdges, from.id, edge.arrowheadId);
+ collectLinks(linkedEdges, to.id, edge.arrowheadId);
+ });
+
+ linkedNodes.forEach((linkedNodes, selectNode) => {
Review Comment:
It might be inevitable in order to clear the previous selection, @LuciferYang . If this works with a large graph without any UI lagging issues, this looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43307:
URL: https://github.com/apache/spark/pull/43307#discussion_r1352726658
##########
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js:
##########
@@ -269,3 +270,47 @@ function togglePlanViz() { // eslint-disable-line no-unused-vars
planVizContainer().style("display", "none");
}
}
+
+/*
+ * Light up the selected node and its linked nodes and edges.
+ */
+function setupSelectionForSparkPlanNode(g) {
+ const linkedNodes = new Map();
+ const linkedEdges = new Map();
+
+ g.edges().forEach(function (e) {
+ const edge = g.edge(e);
+ const from = g.node(e.v);
+ const to = g.node(e.w);
+ collectLinks(linkedNodes, from.id, to.id);
+ collectLinks(linkedNodes, to.id, from.id);
+ collectLinks(linkedEdges, from.id, edge.arrowheadId);
+ collectLinks(linkedEdges, to.id, edge.arrowheadId);
+ });
+
+ linkedNodes.forEach((linkedNodes, selectNode) => {
Review Comment:
It appears that each click currently clears and resets the class of all nodes and edges. Is it possible to update only those nodes and edges that actually change? Please correct me if I'm wrong.
##########
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js:
##########
@@ -269,3 +270,47 @@ function togglePlanViz() { // eslint-disable-line no-unused-vars
planVizContainer().style("display", "none");
}
}
+
+/*
+ * Light up the selected node and its linked nodes and edges.
+ */
+function setupSelectionForSparkPlanNode(g) {
+ const linkedNodes = new Map();
+ const linkedEdges = new Map();
+
+ g.edges().forEach(function (e) {
+ const edge = g.edge(e);
+ const from = g.node(e.v);
+ const to = g.node(e.w);
+ collectLinks(linkedNodes, from.id, to.id);
+ collectLinks(linkedNodes, to.id, from.id);
+ collectLinks(linkedEdges, from.id, edge.arrowheadId);
+ collectLinks(linkedEdges, to.id, edge.arrowheadId);
+ });
+
+ linkedNodes.forEach((linkedNodes, selectNode) => {
Review Comment:
It seems that each click currently clears and resets the class of all nodes and edges. Is it possible to update only those nodes and edges that actually change? Please correct me if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #43307:
URL: https://github.com/apache/spark/pull/43307#issuecomment-1755018728
cc @sarutak @dongjoon-hyun @cloud-fan @HyukjinKwon @zhengruifeng @LuciferYang thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43307:
URL: https://github.com/apache/spark/pull/43307#discussion_r1352676387
##########
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js:
##########
@@ -269,3 +270,47 @@ function togglePlanViz() { // eslint-disable-line no-unused-vars
planVizContainer().style("display", "none");
}
}
+
+/*
+ * Light up the selected node and its linked nodes and edges.
+ */
+function setupSelectionForSparkPlanNode(g) {
+ const linkedNodes = new Map();
+ const linkedEdges = new Map();
+
+ g.edges().forEach(function (e) {
+ const edge = g.edge(e);
+ const from = g.node(e.v);
+ const to = g.node(e.w);
+ collectLinks(linkedNodes, from.id, to.id);
+ collectLinks(linkedNodes, to.id, from.id);
+ collectLinks(linkedEdges, from.id, edge.arrowheadId);
+ collectLinks(linkedEdges, to.id, edge.arrowheadId);
+ });
+
+ linkedNodes.forEach((linkedNodes, selectNode) => {
+ d3.select("#" + selectNode).on("click", () => {
+ planVizContainer()
+ .selectAll("*")
+ .classed("selected", false)
+ .classed("linked", false);
+ d3.select("#" + selectNode + " rect").classed("selected", true);
+ linkedNodes.forEach((linkedNode) => {
+ d3.select("#" + linkedNode + " rect").classed("linked", true);
+ });
+ linkedEdges.get(selectNode).forEach((linkedEdge) => {
+ const arrowHead = d3.select("#" + linkedEdge + " path");
+ arrowHead.classed("linked", true);
+ const arrowShaft = $(arrowHead.node()).parents("g.edgePath").children("path");
Review Comment:
How about using d3's api uniformly?
Like
```
const arrowShaft = d3.select(arrowHead.node().parentNode).select("path");
arrowShaft.classed("linked", true);
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43307:
URL: https://github.com/apache/spark/pull/43307#issuecomment-1755203217
also cc @jasonli-db and @rednaxelafx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #43307:
URL: https://github.com/apache/spark/pull/43307#issuecomment-1757046249
Thanks @dongjoon-hyun @sarutak @LuciferYang @HyukjinKwon and @rednaxelafx
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #43307: [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI
URL: https://github.com/apache/spark/pull/43307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43307:
URL: https://github.com/apache/spark/pull/43307#discussion_r1352822338
##########
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js:
##########
@@ -269,3 +270,47 @@ function togglePlanViz() { // eslint-disable-line no-unused-vars
planVizContainer().style("display", "none");
}
}
+
+/*
+ * Light up the selected node and its linked nodes and edges.
+ */
+function setupSelectionForSparkPlanNode(g) {
+ const linkedNodes = new Map();
+ const linkedEdges = new Map();
+
+ g.edges().forEach(function (e) {
+ const edge = g.edge(e);
+ const from = g.node(e.v);
+ const to = g.node(e.w);
+ collectLinks(linkedNodes, from.id, to.id);
+ collectLinks(linkedNodes, to.id, from.id);
+ collectLinks(linkedEdges, from.id, edge.arrowheadId);
+ collectLinks(linkedEdges, to.id, edge.arrowheadId);
+ });
+
+ linkedNodes.forEach((linkedNodes, selectNode) => {
Review Comment:
Ok, let's consider how to optimize when there is a real bottleneck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #43307:
URL: https://github.com/apache/spark/pull/43307#issuecomment-1756617304
> In that case this new feature might actually make the usability worse when a user clicks on a node and triggers a whole-graph update.
Hi @rednaxelafx @sarutak and @LuciferYang, thanks for the check. I have avoided the whole plan updates in [31cff1f](https://github.com/apache/spark/pull/43307/commits/31cff1fced1f38423c240993891b27c128e77121). Note that we do not rerender the whole plan after click, is there any reason to add a checkbox here.
Thanks for the side note @rednaxelafx, I think I'll go and experience it and bring some interesting things back to Spark UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "rednaxelafx (via GitHub)" <gi...@apache.org>.
rednaxelafx commented on PR #43307:
URL: https://github.com/apache/spark/pull/43307#issuecomment-1755943552
A nice improvement to the UI 👍
But there's a dilemma: this feature is supposed to improve the UI's usability on large plans. For us it's quite common to have very large query plan graphs and the existing UI is already quite heavy (takes a while to render...).
In that case this new feature might actually make the usability worse when a user clicks on a node and triggers a whole-graph update.
Can we have either a Spark conf or a checkbox on the UI to allow users to opt-out of this feature when they find it counterproductive in their scenario?
Side note: when I used to work on the HotSpot C2 compiler, I used the IdealGraphVisualizer (IGV) a lot to visualize the C2 IR. It also provides node selection and highlighting capabilities, and in addition it supports "node hiding" -- you can choose to focus on a subset of nodes and hide all of the other nodes, and optionally show the immediate neighbor nodes of the selected subgraph to be shown in lower opacity, and double-clicking on these neighbors will add them to the selection.
It was super useful and my workflow was heavily dependent on that. I'd start out from the specific node in question and gradually expand out to cover enough context, and try to figure out what the problem was. In a graph of thousands of nodes this allowed me to work with mostly a couple dozen nodes at a time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45480][SQL][UI] Selectable Spark Plan Node on UI [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #43307:
URL: https://github.com/apache/spark/pull/43307#issuecomment-1756584967
@yaooqinn Looks like a nice feature!
> Can we have either a Spark conf or a checkbox on the UI to allow users to opt-out of this feature when they find it counterproductive in their scenario?
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org