You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Alexey Diomin (JIRA)" <ji...@apache.org> on 2011/03/04 10:28:37 UTC

[jira] Created: (HADOOP-7162) call method without catching

call method without catching
----------------------------

                 Key: HADOOP-7162
                 URL: https://issues.apache.org/jira/browse/HADOOP-7162
             Project: Hadoop Common
          Issue Type: Bug
          Components: util
    Affects Versions: 0.21.0
            Reporter: Alexey Diomin
            Priority: Minor


in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
call method twice:
1. for init variable
2. for getting data



-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-7162) FsShell: call srcFs.listStatus(src) twice

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002990#comment-13002990 ] 

Hudson commented on HADOOP-7162:
--------------------------------

Integrated in Hadoop-Common-trunk #621 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/621/])
    HADOOP-7162. Rmove a duplicated call FileSystem.listStatus(..) in FsShell.  Contributed by Alexey Diomin


> FsShell: call srcFs.listStatus(src) twice
> -----------------------------------------
>
>                 Key: HADOOP-7162
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7162
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.21.0
>            Reporter: Alexey Diomin
>            Assignee: Alexey Diomin
>            Priority: Minor
>             Fix For: 0.21.1, 0.22.0, 0.23.0
>
>         Attachments: HDFS-7162.path
>
>
> in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
> call method twice:
> 1. for init variable
> 2. for getting data

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-7162) FsShell: call srcFs.listStatus(src) twice

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005863#comment-13005863 ] 

Hudson commented on HADOOP-7162:
--------------------------------

Integrated in Hadoop-Common-22-branch #32 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/32/])
    

> FsShell: call srcFs.listStatus(src) twice
> -----------------------------------------
>
>                 Key: HADOOP-7162
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7162
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.21.0
>            Reporter: Alexey Diomin
>            Assignee: Alexey Diomin
>            Priority: Minor
>             Fix For: 0.21.1, 0.22.0, 0.23.0
>
>         Attachments: HDFS-7162.path
>
>
> in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
> call method twice:
> 1. for init variable
> 2. for getting data

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HADOOP-7162) call method without catching

Posted by "Alexey Diomin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Diomin updated HADOOP-7162:
----------------------------------

    Attachment: HDFS-7162.path

> call method without catching
> ----------------------------
>
>                 Key: HADOOP-7162
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7162
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.21.0
>            Reporter: Alexey Diomin
>            Priority: Minor
>         Attachments: HDFS-7162.path
>
>
> in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
> call method twice:
> 1. for init variable
> 2. for getting data

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-7162) call method without catching

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002736#comment-13002736 ] 

Hadoop QA commented on HADOOP-7162:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12472654/HDFS-7162.path
  against trunk revision 1077811.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/302//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/302//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/302//console

This message is automatically generated.

> call method without catching
> ----------------------------
>
>                 Key: HADOOP-7162
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7162
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.21.0
>            Reporter: Alexey Diomin
>            Assignee: Alexey Diomin
>            Priority: Minor
>         Attachments: HDFS-7162.path
>
>
> in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
> call method twice:
> 1. for init variable
> 2. for getting data

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-7162) FsShell: call srcFs.listStatus(src) twice

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-7162:
-------------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I have committed this.  Thanks, Alexey!

> FsShell: call srcFs.listStatus(src) twice
> -----------------------------------------
>
>                 Key: HADOOP-7162
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7162
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.21.0
>            Reporter: Alexey Diomin
>            Assignee: Alexey Diomin
>            Priority: Minor
>             Fix For: 0.21.1, 0.22.0, 0.23.0
>
>         Attachments: HDFS-7162.path
>
>
> in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
> call method twice:
> 1. for init variable
> 2. for getting data

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-7162) call method without catching

Posted by "Alexey Diomin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Diomin updated HADOOP-7162:
----------------------------------

    Status: Patch Available  (was: Open)

> call method without catching
> ----------------------------
>
>                 Key: HADOOP-7162
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7162
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.21.0
>            Reporter: Alexey Diomin
>            Priority: Minor
>         Attachments: HDFS-7162.path
>
>
> in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
> call method twice:
> 1. for init variable
> 2. for getting data

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-7162) call method without catching

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-7162:
-------------------------------------------

        Assignee: Alexey Diomin
    Hadoop Flags: [Reviewed]

+1 patch looks good.

> call method without catching
> ----------------------------
>
>                 Key: HADOOP-7162
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7162
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.21.0
>            Reporter: Alexey Diomin
>            Assignee: Alexey Diomin
>            Priority: Minor
>         Attachments: HDFS-7162.path
>
>
> in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
> call method twice:
> 1. for init variable
> 2. for getting data

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-7162) FsShell: call srcFs.listStatus(src) twice

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002885#comment-13002885 ] 

Hudson commented on HADOOP-7162:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #517 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/517/])
    

> FsShell: call srcFs.listStatus(src) twice
> -----------------------------------------
>
>                 Key: HADOOP-7162
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7162
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.21.0
>            Reporter: Alexey Diomin
>            Assignee: Alexey Diomin
>            Priority: Minor
>             Fix For: 0.21.1, 0.22.0, 0.23.0
>
>         Attachments: HDFS-7162.path
>
>
> in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
> call method twice:
> 1. for init variable
> 2. for getting data

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-7162) FsShell: call srcFs.listStatus(src) twice

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-7162:
-------------------------------------------

      Component/s:     (was: util)
                   fs
    Fix Version/s: 0.23.0
                   0.22.0
                   0.21.1
          Summary: FsShell: call srcFs.listStatus(src) twice  (was: call method without catching)

> FsShell: call srcFs.listStatus(src) twice
> -----------------------------------------
>
>                 Key: HADOOP-7162
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7162
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.21.0
>            Reporter: Alexey Diomin
>            Assignee: Alexey Diomin
>            Priority: Minor
>             Fix For: 0.21.1, 0.22.0, 0.23.0
>
>         Attachments: HDFS-7162.path
>
>
> in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
> call method twice:
> 1. for init variable
> 2. for getting data

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira