You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vladimir Ivanov (JIRA)" <ji...@apache.org> on 2006/12/22 15:34:26 UTC
[jira] Created: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
[drlvm][build] tests continue run after test failure
----------------------------------------------------
Key: HARMONY-2859
URL: http://issues.apache.org/jira/browse/HARMONY-2859
Project: Harmony
Issue Type: Improvement
Components: DRLVM
Reporter: Vladimir Ivanov
Priority: Minor
The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463555 ]
Alexey Varlamov commented on HARMONY-2859:
------------------------------------------
Vladimir, here is the updated variant with suggested improvements and other minor fixes (correct appending to *.failed files and their location).
BTW, we can now easily add printing summary at the very end, listing all failed tests.
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: HARMONY-2859.diff, test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov resolved HARMONY-2859.
--------------------------------------
Resolution: Fixed
Fixed at r495194, please verify it works as expected.
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: HARMONY-2859.diff, test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463557 ]
Gregory Shimansky commented on HARMONY-2859:
--------------------------------------------
> One more issue, do we need to change the default behavior?
> I believe current fail-fast variant is more convenient for general use, and CC can easily supply extra option for full run.
I would prefer to keep the default behavior. It makes it easier to catch failing test when some patch breaks test run.
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: HARMONY-2859.diff, test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463545 ]
Alexey Varlamov commented on HARMONY-2859:
------------------------------------------
Vladimir, this is right move. I'm see the following areas for improvement:
1) Use equivalent <fail if="test.failed" unless="run.all.tests.flag"> instead of
+ <fail>
+ <condition>
+ <and>
+ <isset property="test.failed" />
+ <not>
+ <isset property="run.all.tests.flag" />
+ </not>
+ </and>
+ </condition>
+ </fail>
2) Do not introduce status property for each suite, use just one property - intersection is harmless here.
3) Omit ".flag" suffix.
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463553 ]
Alexey Varlamov commented on HARMONY-2859:
------------------------------------------
One more issue, do we need to change the default behavior?
I believe current fail-fast variant is more convenient for general use, and CC can easily supply extra option for full run.
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463192 ]
Vladimir Ivanov commented on HARMONY-2859:
------------------------------------------
While test runs implemented through the <antcall> the variables from this runs is not available to parent ant. I pass it with help of external files (I don't want to do new implementation of test run at least now). If you know other solution gives me example and I redo my patch.
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Priority: Minor
> Attachments: test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463287 ]
Vladimir Ivanov commented on HARMONY-2859:
------------------------------------------
new patch created (files used locally in the xml's)
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2859?page=comments#action_12460996 ]
Alexey Varlamov commented on HARMONY-2859:
------------------------------------------
Vladimir, I like the idea but dislike impl - looks too verbose and non-modular.
IMO it should be possible to set/pass some flag which prevents early failing, and use it like <fail unless="run.all"> instead of cumbersome file-touching constructs.
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: http://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Priority: Minor
> Attachments: test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov reassigned HARMONY-2859:
----------------------------------------
Assignee: Alexey Varlamov
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Ivanov updated HARMONY-2859:
-------------------------------------
Attachment: test.patch
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov updated HARMONY-2859:
-------------------------------------
Attachment: HARMONY-2859.diff
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: HARMONY-2859.diff, test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463239 ]
Alexey Varlamov commented on HARMONY-2859:
------------------------------------------
>From what I can see, antcall is only used to iterate runs of kernel, smoke and jvmti tests. So there is no need to re-implement runs, just move fail-checks up to top-level target. Moreover this is already done for kernel and smoke tests, and minor fix is needed for jvmti tests. I guess a patch would be even smaller than current ;)
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Priority: Minor
> Attachments: test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463827 ]
Vladimir Ivanov commented on HARMONY-2859:
------------------------------------------
As I understood your patch keep the default behavior and to run all test the "-Drun.all.tests=true" options should be added. It is OK for me.
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: HARMONY-2859.diff, test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464132 ]
Vladimir Ivanov commented on HARMONY-2859:
------------------------------------------
verified, thanks
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: HARMONY-2859.diff, test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov closed HARMONY-2859.
------------------------------------
BTW, since NY2007 you should be able to close reported JIRAs yourself.
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: https://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Alexey Varlamov
> Priority: Minor
> Attachments: HARMONY-2859.diff, test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2859) [drlvm][build] tests continue run
after test failure
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2859?page=all ]
Vladimir Ivanov updated HARMONY-2859:
-------------------------------------
Attachment: test.patch
patch
> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
> Key: HARMONY-2859
> URL: http://issues.apache.org/jira/browse/HARMONY-2859
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Priority: Minor
> Attachments: test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira