Re: [PR] CASSANDRA-21389 trunk Harden snapshot names on server side [cassandra]

["smiklosovic (via GitHub)" <gi...@apache.org>]

smiklosovic commented on PR #4826:
URL: https://github.com/apache/cassandra/pull/4826#issuecomment-4593502582

   @frankgh no objections with more refined message with allowed chars and length but I am not sure about list/clear snapshot validation. It is overkill. In 6.0+, because it is on manager, we are literally checking snapshot name against user's argument. If it does not match then nothing is done. So it is irrelevant that a user wants to clear "../../abc", it will just filter snapshots with such a name - and since it is not possible to create a snapshot with a name like that this kind of a predicate always yields false, so nothing happens. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org