You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Eugene Koontz (JIRA)" <ji...@apache.org> on 2011/06/21 23:25:47 UTC
[jira] [Created] (ZOOKEEPER-1103) In QuorumTest, use the same "for
( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders
as in testSessionMove.
In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
---------------------------------------------------------------------------------------------------------------------------------
Key: ZOOKEEPER-1103
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
Project: ZooKeeper
Issue Type: Improvement
Components: tests
Affects Versions: 3.4.0
Reporter: Eugene Koontz
Assignee: Eugene Koontz
Priority: Minor
Patrick Hunt writes:
"Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
of sleep in testSessionMove in the same class for a better way to do
this. I had gone through all the tests a while back, replacing all the
"sleep(x)" with something like this testSessionMove pattern (retry
with a max limit that's very long). During reviews we should look for
anti-patterns like this and address them before commit."
So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1103) In QuorumTest, use the same "for
( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders
as in testSessionMove.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1103:
------------------------------------
Fix Version/s: 3.4.0
3.3.4
This should be fixed in both branch 3.3 and trunk.
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1103) In QuorumTest, use the same
"for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053430#comment-13053430 ]
Hudson commented on ZOOKEEPER-1103:
-----------------------------------
Integrated in ZooKeeper-trunk #1221 (See [https://builds.apache.org/job/ZooKeeper-trunk/1221/])
Fixed a problem introduced by the first patch for ZOOKEEPER-1103 (phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1138595
Files :
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/QuorumTest.java
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_2.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1103_branch_3_3_try2.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1103) In QuorumTest, use the same
"for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052902#comment-13052902 ]
Patrick Hunt commented on ZOOKEEPER-1103:
-----------------------------------------
disregard this last failure (only runs patches against trunk, which is specifically for branch 3.3)
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1103) In QuorumTest, use the same
"for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052900#comment-13052900 ]
Hadoop QA commented on ZOOKEEPER-1103:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483366/ZOOKEEPER-1103_branch_3_3.patch
against trunk revision 1138213.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/343//console
This message is automatically generated.
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (ZOOKEEPER-1103) In QuorumTest, use the same "for
( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders
as in testSessionMove.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reopened ZOOKEEPER-1103:
-------------------------------------
My bad, there's an issue with this change (didn't show up on my testing but I can see why on jenkins). I'll fix this.
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1103) In QuorumTest, use the same "for
( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders
as in testSessionMove.
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1103:
-------------------------------------
Attachment: ZOOKEEPER-1103.patch
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: ZOOKEEPER-1103.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1103) In QuorumTest, use the same "for
( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders
as in testSessionMove.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1103:
------------------------------------
Attachment: ZOOKEEPER-1103_branch_3_3.patch
Minor tweak to compile against branch 3.3.
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1103) In QuorumTest, use the same "for
( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders
as in testSessionMove.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1103:
------------------------------------
Affects Version/s: 3.3.3
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ZOOKEEPER-1103) In QuorumTest, use the same "for
( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders
as in testSessionMove.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt resolved ZOOKEEPER-1103.
-------------------------------------
Resolution: Fixed
Updated to check success/fail correctly. (sorry for missing that!)
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_2.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1103_branch_3_3_try2.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1103) In QuorumTest, use the same
"for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052869#comment-13052869 ]
Hadoop QA commented on ZOOKEEPER-1103:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483355/ZOOKEEPER-1103.patch
against trunk revision 1138100.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/342//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/342//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/342//console
This message is automatically generated.
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1103) In QuorumTest, use the same "for
( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders
as in testSessionMove.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1103:
------------------------------------
Attachment: ZOOKEEPER-1103_branch_3_3_try2.patch
ZOOKEEPER-1103_2.patch
> In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1103
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_2.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1103_branch_3_3_try2.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira