You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by bc...@apache.org on 2017/05/10 17:55:09 UTC
[trafficserver] branch master updated: coverity 1021747:
Uninitialized pointer field
This is an automated email from the ASF dual-hosted git repository.
bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new 1d251b2 coverity 1021747: Uninitialized pointer field
1d251b2 is described below
commit 1d251b227592cfd6c9cc4f1f7219cbfb462204cd
Author: Bryan Call <bc...@apache.org>
AuthorDate: Wed May 10 13:24:03 2017 -0400
coverity 1021747: Uninitialized pointer field
---
iocore/hostdb/P_HostDBProcessor.h | 29 +++++++++--------------------
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/iocore/hostdb/P_HostDBProcessor.h b/iocore/hostdb/P_HostDBProcessor.h
index 49d5fea..860248a 100644
--- a/iocore/hostdb/P_HostDBProcessor.h
+++ b/iocore/hostdb/P_HostDBProcessor.h
@@ -427,25 +427,25 @@ struct HostDBContinuation : public Continuation {
Action action;
HostDBMD5 md5;
// IpEndpoint ip;
- unsigned int ttl;
+ unsigned int ttl = 0;
// HostDBMark db_mark; ///< Target type.
/// Original IP address family style. Note this will disagree with
/// @a md5.db_mark when doing a retry on an alternate family. The retry
/// logic depends on it to avoid looping.
- HostResStyle host_res_style; ///< Address family priority.
- int dns_lookup_timeout;
+ HostResStyle host_res_style = DEFAULT_OPTIONS.host_res_style; ///< Address family priority.
+ int dns_lookup_timeout = DEFAULT_OPTIONS.timeout;
// INK_MD5 md5;
- Event *timeout;
- Continuation *from_cont;
+ Event *timeout = nullptr;
+ Continuation *from_cont = nullptr;
HostDBApplicationInfo app;
- int probe_depth;
- size_t current_iterate_pos;
+ int probe_depth = 0;
+ size_t current_iterate_pos = 0;
// char name[MAXDNAME];
// int namelen;
char md5_host_name_store[MAXDNAME + 1]; // used as backing store for @a md5
char srv_target_name[MAXDNAME];
// void *m_pDS;
- Action *pending_action;
+ Action *pending_action = nullptr;
unsigned int missing : 1;
unsigned int force_dns : 1;
@@ -498,18 +498,7 @@ struct HostDBContinuation : public Continuation {
int make_get_message(char *buf, int len);
int make_put_message(HostDBInfo *r, Continuation *c, char *buf, int len);
- HostDBContinuation()
- : Continuation(nullptr),
- ttl(0),
- host_res_style(DEFAULT_OPTIONS.host_res_style),
- dns_lookup_timeout(DEFAULT_OPTIONS.timeout),
- timeout(0),
- from_cont(0),
- probe_depth(0),
- current_iterate_pos(0),
- missing(false),
- force_dns(DEFAULT_OPTIONS.force_dns),
- round_robin(false)
+ HostDBContinuation() : missing(false), force_dns(DEFAULT_OPTIONS.force_dns), round_robin(false)
{
ink_zero(md5_host_name_store);
ink_zero(md5.hash);
--
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].