You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/22 22:40:53 UTC
[GitHub] [incubator-nuttx-apps] w8jcik opened a new pull request #339: Use Markdown for readmes (just `examples` directory)
w8jcik opened a new pull request #339:
URL: https://github.com/apache/incubator-nuttx-apps/pull/339
It is like this PR https://github.com/apache/incubator-nuttx-apps/pull/337, but just one directory, for easier review. I have reviewed this change few times, so from my side, it is ready to be merged.
I checked again that despite `git mv` GitHub shows file as deleted and created https://github.com/apache/incubator-nuttx-apps/commit/14b40d7df66b6b6748818162810cdc98cff5f93b. So it is not very helpful for the review. One need to use some desktop tool or these links:
- [examples/tcpblaster/README.md](https://github.com/w8jcik/incubator-nuttx-apps/blob/doc%2Fexamples-md/examples/tcpblaster/README.md)
- [examples/flash_test/README.md](https://github.com/w8jcik/incubator-nuttx-apps/blob/doc%2Fexamples-md/examples/flash_test/README.md)
- [examples/camera/README.md](https://github.com/w8jcik/incubator-nuttx-apps/blob/doc%2Fexamples-md/examples/camera/README.md)
- [examples/json/README.md](https://github.com/w8jcik/incubator-nuttx-apps/blob/doc%2Fexamples-md/examples/json/README.md)
- [examples/bastest/README.md](https://github.com/w8jcik/incubator-nuttx-apps/blob/doc%2Fexamples-md/examples/bastest/README.md)
- [examples/flowc/README.md](https://github.com/w8jcik/incubator-nuttx-apps/blob/doc%2Fexamples-md/examples/flowc/README.md)
- [examples/pdcurses/README.md](https://github.com/w8jcik/incubator-nuttx-apps/blob/doc%2Fexamples-md/examples/pdcurses/README.md)
- [examples/telnetd/README.md](https://github.com/w8jcik/incubator-nuttx-apps/blob/doc%2Fexamples-md/examples/telnetd/README.md)
- [examples/README.md](https://github.com/w8jcik/incubator-nuttx-apps/blob/doc%2Fexamples-md/examples/README.md)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #339: Use Markdown for readmes (just `examples` directory)
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #339:
URL: https://github.com/apache/incubator-nuttx-apps/pull/339#issuecomment-662742475
> Again, despite `git mv` GitHub shows the files as deleted and created [14b40d7](https://github.com/apache/incubator-nuttx-apps/commit/14b40d7df66b6b6748818162810cdc98cff5f93b). So it is not very helpful for the review.
You might need to use -M to let git autodetect the moved file when diff'ing.
...
A little investigation shows that you can diff any two different files with different revisions. For example, this works (but is not really meaningful):
git diff 82debdc2139ebb27071d230a66612db2f1ac3a11:TODO README.txt
That shows the difference between the current README.txt and and old revision of the TODO list. So in general you should be able to do:
git diff <revision>:README.txt README.md
Where `<revision>` is the revision just before the `git mv`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] w8jcik edited a comment on pull request #339: Use Markdown for readmes (just `examples` directory)
Posted by GitBox <gi...@apache.org>.
w8jcik edited a comment on pull request #339:
URL: https://github.com/apache/incubator-nuttx-apps/pull/339#issuecomment-662749580
> You might need to use -M to let git autodetect the moved file when diffing.
Hi Greg, my git and other tools seems to be fine. It is just about GitHub not showing the diff, so it is difficult to do proper review here. Maybe this would help https://github.com/apache/incubator-nuttx-apps/pull/337#issuecomment-662741659, but I am not sure. (GitHub seems to be going through some difficult transition, even the link above doesn't go to the proper comment. It is the last comment in the other PR, where I am suggesting that you could create a branch for me.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #339: Use Markdown for readmes (just `examples` directory)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #339:
URL: https://github.com/apache/incubator-nuttx-apps/pull/339#issuecomment-662788309
@w8jcik @patacongo, you can review the individual patch from 'Commits' tab:
https://github.com/apache/incubator-nuttx-apps/pull/339/commits/c3295a6359ebbfb046c76d0d0e5c04e5ada42a7b
The 'Files Changed' always show the final result which isn't smart as git in the complex case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] w8jcik commented on pull request #339: Use Markdown for readmes (just `examples` directory)
Posted by GitBox <gi...@apache.org>.
w8jcik commented on pull request #339:
URL: https://github.com/apache/incubator-nuttx-apps/pull/339#issuecomment-662749580
> You might need to use -M to let git autodetect the moved file when diffing.
Hi Greg, my git and other tools seems to be fine. It is just about GitHub not showing the diff, so it is difficult to do proper review here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #339: Use Markdown for readmes (just `examples` directory)
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #339:
URL: https://github.com/apache/incubator-nuttx-apps/pull/339#issuecomment-662742475
> Again, despite `git mv` GitHub shows the files as deleted and created [14b40d7](https://github.com/apache/incubator-nuttx-apps/commit/14b40d7df66b6b6748818162810cdc98cff5f93b). So it is not very helpful for the review.
You might need to use -M to let git autodetect the moved file when diffing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] w8jcik closed pull request #339: Use Markdown for readmes (just `examples` directory)
Posted by GitBox <gi...@apache.org>.
w8jcik closed pull request #339:
URL: https://github.com/apache/incubator-nuttx-apps/pull/339
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] w8jcik edited a comment on pull request #339: Use Markdown for readmes (just `examples` directory)
Posted by GitBox <gi...@apache.org>.
w8jcik edited a comment on pull request #339:
URL: https://github.com/apache/incubator-nuttx-apps/pull/339#issuecomment-662749580
> You might need to use -M to let git autodetect the moved file when diffing.
Hi Greg, my git and other tools seems to be fine. It is just about GitHub not showing the diff, so it is difficult to do proper review here. Maybe this would help https://github.com/apache/incubator-nuttx-apps/pull/337#issuecomment-662741659, but I am not sure.
(GitHub seems to be going through some difficult transition, even the link above doesn't go to the proper comment. It is the last comment in the other PR, where I am suggesting that you could create a branch for me.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org