[jira] [Updated] (HBASE-8719) Fix responseTooSlow formatting

["Jean-Daniel Cryans (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-8719:
--------------------------------------

    Attachment: HBASE-8719.patch

Here's a first pass. Two things:

- The caller disconnected was super easy to fix since we call it from HRegion and can pass the region name down.

- The responseTooSlow/Big log prints the Call and the params need to be parsed. This part is very different between 0.94 and 0.96 and I have a patch for both but right now just posting for 0.96 in which I simply add more parsing to ProtobufUtil.getShortTextFormat(), and is it just me or that class is monstrous? 
                
> Fix responseTooSlow formatting
> ------------------------------
>
>                 Key: HBASE-8719
>                 URL: https://issues.apache.org/jira/browse/HBASE-8719
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.95.2
>
>         Attachments: HBASE-8719.patch
>
>
> Make sure the responseTooSlow, etc., logs region at least and possibly row.
> As one well-known tall man once said:
> {code}
> I really hate this:
> org.apache.hadoop.hbase.ipc.CallerDisconnectedException: Aborting call next(-5472965299350279760, 101), rpc version=1, client version=29, methodsFingerPrint=-56040613 from 10.4.21.36:59647 after 192373 ms, since caller disconnected
> WHICH REGION WAS IT???
> ....
> 2013-06-09 01:11:03,574 WARN org.apache.hadoop.ipc.HBaseServer: (responseTooSlow): {"processingtimems":1141537,"call":"next(6527877619467313103, 101), rpc version=1, client version=29, methodsFingerPrint=-56040613","client":"10.4.21.44:41453","starttimems":1370739122036,"queuetimems":0,"class":"HRegionServer","responsesize":293994,"method":"next"}
> which region is this?
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira