[jira] [Comment Edited] (RATIS-289) Optimize readStateMachine by allowing to enqueue multiple read requests in parallel

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568570#comment-16568570 ] 

Tsz Wo Nicholas Sze edited comment on RATIS-289 at 8/3/18 6:21 PM:
-------------------------------------------------------------------

Thanks for the update.
- In EntryWithData.getEntry(), the condition in the last if-statement is wrong.  If should be no "!".
- It is better to keep buf as List<LogEntryProto> and call entry.getEntry() in addEntry(..) as shown in [this comment|https://issues.apache.org/jira/browse/RATIS-289?focusedCommentId=16567435&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16567435].  Then, we can avoid creating the new protos List.



was (Author: szetszwo):
Thanks for the update.
- In EntryWithData.getEntry(), the condition in the last if-statement is wrong.  If should be no "!".
- It is better to keep buf as List<LogEntryProto> and call entry.getEntry() in addEntry(..) as shown in [this comment|https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13176344&commentId=16567435].  Then, we can avoid creating the new protos List.


> Optimize readStateMachine by allowing to enqueue multiple read requests in parallel
> -----------------------------------------------------------------------------------
>
>                 Key: RATIS-289
>                 URL: https://issues.apache.org/jira/browse/RATIS-289
>             Project: Ratis
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 0.3.0
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>            Priority: Major
>             Fix For: 0.3.0
>
>         Attachments: RATIS-289.002.patch
>
>
> Currently the data is read from state machine using the getEntryWithData api. However this api does not let multiple reads to state machine to happen in parallel.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)