You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/18 17:10:06 UTC

[GitHub] [shardingsphere] gxxiong opened a new pull request, #22960: Table mode cannot be verified by automatic sharding algorithm

gxxiong opened a new pull request, #22960:
URL: https://github.com/apache/shardingsphere/pull/22960

   Fixes #22926 .
   
   Changes proposed in this pull request:
     -Table mode cannot be verified by automatic sharding algorithm
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [X] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [X] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [X] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] gxxiong commented on a diff in pull request #22960: Table mode cannot be verified by automatic sharding algorithm

Posted by GitBox <gi...@apache.org>.
gxxiong commented on code in PR #22960:
URL: https://github.com/apache/shardingsphere/pull/22960#discussion_r1056843303


##########
features/sharding/distsql/handler/src/test/java/org/apache/shardingsphere/sharding/distsql/fixture/sharding/HintInlineShardingAlgorithmFixture.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.distsql.fixture.sharding;
+
+import com.google.common.base.Preconditions;
+import groovy.lang.Closure;
+import groovy.util.Expando;
+import lombok.Getter;
+import org.apache.shardingsphere.infra.util.expr.InlineExpressionParser;
+import org.apache.shardingsphere.sharding.api.sharding.hint.HintShardingAlgorithm;
+import org.apache.shardingsphere.sharding.api.sharding.hint.HintShardingValue;
+
+import java.util.Collection;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+/**
+ * Hint inline sharding algorithm.
+ */
+public final class HintInlineShardingAlgorithmFixture implements HintShardingAlgorithm<Comparable<?>> {
+    
+    private static final String ALGORITHM_EXPRESSION_KEY = "algorithm-expression";
+    
+    private static final String DEFAULT_ALGORITHM_EXPRESSION = "${value}";
+    
+    private static final String HINT_INLINE_VALUE_PROPERTY_NAME = "value";
+    
+    @Getter
+    private Properties props = new Properties();
+    
+    private String algorithmExpression;
+    
+    @Override
+    public void init(final Properties props) {
+        this.props = props;
+        algorithmExpression = getAlgorithmExpression(props);
+    }
+    
+    private String getAlgorithmExpression(final Properties props) {
+        String algorithmExpression = props.getProperty(ALGORITHM_EXPRESSION_KEY, DEFAULT_ALGORITHM_EXPRESSION);
+        Preconditions.checkNotNull(algorithmExpression, "Inline sharding algorithm expression can not be null.");
+        return InlineExpressionParser.handlePlaceHolder(algorithmExpression.trim());
+    }
+    
+    @Override
+    public Collection<String> doSharding(final Collection<String> availableTargetNames, final HintShardingValue<Comparable<?>> shardingValue) {
+        return shardingValue.getValues().isEmpty() ? availableTargetNames : shardingValue.getValues().stream().map(this::doSharding).collect(Collectors.toList());
+    }
+    
+    private String doSharding(final Comparable<?> shardingValue) {
+        Closure<?> closure = createClosure();
+        closure.setProperty(HINT_INLINE_VALUE_PROPERTY_NAME, shardingValue);
+        return closure.call().toString();
+    }
+    
+    private Closure<?> createClosure() {
+        Closure<?> result = new InlineExpressionParser(algorithmExpression).evaluateClosure().rehydrate(new Expando(), null, null);
+        result.setResolveStrategy(Closure.DELEGATE_ONLY);
+        return result;
+    }
+    
+    @Override
+    public String getType() {
+        return "HINT_INLINE";

Review Comment:
   Need to build shardingAlgorithm to judge whether it is ShardingAutoTableAlgorithm, algorithm type cannot be built



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22960: Table mode cannot be verified by automatic sharding algorithm

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #22960:
URL: https://github.com/apache/shardingsphere/pull/22960#discussion_r1056893124


##########
features/sharding/distsql/handler/src/test/java/org/apache/shardingsphere/sharding/distsql/fixture/sharding/HintInlineShardingAlgorithmFixture.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.distsql.fixture.sharding;
+
+import com.google.common.base.Preconditions;
+import groovy.lang.Closure;
+import groovy.util.Expando;
+import lombok.Getter;
+import org.apache.shardingsphere.infra.util.expr.InlineExpressionParser;
+import org.apache.shardingsphere.sharding.api.sharding.hint.HintShardingAlgorithm;
+import org.apache.shardingsphere.sharding.api.sharding.hint.HintShardingValue;
+
+import java.util.Collection;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+/**
+ * Hint inline sharding algorithm.
+ */
+public final class HintInlineShardingAlgorithmFixture implements HintShardingAlgorithm<Comparable<?>> {
+    
+    private static final String ALGORITHM_EXPRESSION_KEY = "algorithm-expression";
+    
+    private static final String DEFAULT_ALGORITHM_EXPRESSION = "${value}";
+    
+    private static final String HINT_INLINE_VALUE_PROPERTY_NAME = "value";
+    
+    @Getter
+    private Properties props = new Properties();
+    
+    private String algorithmExpression;
+    
+    @Override
+    public void init(final Properties props) {
+        this.props = props;
+        algorithmExpression = getAlgorithmExpression(props);
+    }
+    
+    private String getAlgorithmExpression(final Properties props) {
+        String algorithmExpression = props.getProperty(ALGORITHM_EXPRESSION_KEY, DEFAULT_ALGORITHM_EXPRESSION);
+        Preconditions.checkNotNull(algorithmExpression, "Inline sharding algorithm expression can not be null.");
+        return InlineExpressionParser.handlePlaceHolder(algorithmExpression.trim());
+    }
+    
+    @Override
+    public Collection<String> doSharding(final Collection<String> availableTargetNames, final HintShardingValue<Comparable<?>> shardingValue) {
+        return shardingValue.getValues().isEmpty() ? availableTargetNames : shardingValue.getValues().stream().map(this::doSharding).collect(Collectors.toList());
+    }
+    
+    private String doSharding(final Comparable<?> shardingValue) {
+        Closure<?> closure = createClosure();
+        closure.setProperty(HINT_INLINE_VALUE_PROPERTY_NAME, shardingValue);
+        return closure.call().toString();
+    }
+    
+    private Closure<?> createClosure() {
+        Closure<?> result = new InlineExpressionParser(algorithmExpression).evaluateClosure().rehydrate(new Expando(), null, null);
+        result.setResolveStrategy(Closure.DELEGATE_ONLY);
+        return result;
+    }
+    
+    @Override
+    public String getType() {
+        return "HINT_INLINE";

Review Comment:
   But these SPIs have the same type name as the built-in algorithms (like `INLINE`), can we tweak this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #22960: Table mode cannot be verified by automatic sharding algorithm

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #22960:
URL: https://github.com/apache/shardingsphere/pull/22960#issuecomment-1365671301

   Hi @gxxiong 
   This is an important PR, thanks for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #22960: Table mode cannot be verified by automatic sharding algorithm

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22960:
URL: https://github.com/apache/shardingsphere/pull/22960#issuecomment-1357400582

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22960?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22960](https://codecov.io/gh/apache/shardingsphere/pull/22960?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b085a82) into [master](https://codecov.io/gh/apache/shardingsphere/commit/aaa0f410ca0982a9912dd9b77e3f8fe681852cff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aaa0f41) will **decrease** coverage by `0.02%`.
   > The diff coverage is `43.80%`.
   
   > :exclamation: Current head b085a82 differs from pull request most recent head caf7542. Consider uploading reports for the commit caf7542 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #22960      +/-   ##
   ============================================
   - Coverage     49.64%   49.62%   -0.03%     
   - Complexity     2451     2455       +4     
   ============================================
     Files          4144     4142       -2     
     Lines         57822    57842      +20     
     Branches       9065     9072       +7     
   ============================================
   - Hits          28704    28702       -2     
   - Misses        26601    26617      +16     
   - Partials       2517     2523       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...re/agent/core/plugin/PluginBootServiceManager.java](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vUGx1Z2luQm9vdFNlcnZpY2VNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../yaml/swapper/YamlAdvisorConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4veWFtbC9zd2FwcGVyL1lhbWxBZHZpc29yQ29uZmlndXJhdGlvblN3YXBwZXIuamF2YQ==) | `8.33% <0.00%> (ø)` | |
   | [...core/transformer/builder/advise/AdviceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS90cmFuc2Zvcm1lci9idWlsZGVyL2FkdmlzZS9BZHZpY2VGYWN0b3J5LmphdmE=) | `83.33% <ø> (ø)` | |
   | [.../transformer/builder/advise/JDBCAdviceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS90cmFuc2Zvcm1lci9idWlsZGVyL2FkdmlzZS9KREJDQWR2aWNlRmFjdG9yeS5qYXZh) | `12.50% <ø> (ø)` | |
   | [...transformer/builder/advise/ProxyAdviceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS90cmFuc2Zvcm1lci9idWlsZGVyL2FkdmlzZS9Qcm94eUFkdmljZUZhY3RvcnkuamF2YQ==) | `75.00% <ø> (ø)` | |
   | [...ging/base/BaseLoggingAdvisorDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9sb2dnaW5nL2Jhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi9sb2dnaW5nL2Jhc2UvQmFzZUxvZ2dpbmdBZHZpc29yRGVmaW5pdGlvblNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...dvice/adviser/impl/CommandExecutorTaskAdviser.java](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL2NvcmUvYWR2aWNlL2FkdmlzZXIvaW1wbC9Db21tYW5kRXhlY3V0b3JUYXNrQWR2aXNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...vice/adviser/impl/JDBCExecutorCallbackAdviser.java](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL2NvcmUvYWR2aWNlL2FkdmlzZXIvaW1wbC9KREJDRXhlY3V0b3JDYWxsYmFja0FkdmlzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...re/advice/adviser/impl/SQLParserEngineAdviser.java](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL2NvcmUvYWR2aWNlL2FkdmlzZXIvaW1wbC9TUUxQYXJzZXJFbmdpbmVBZHZpc2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...shardingsphere/infra/instance/ComputeNodeData.java](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9pbnN0YW5jZS9Db21wdXRlTm9kZURhdGEuamF2YQ==) | `0.00% <ø> (ø)` | |
   | ... and [21 more](https://codecov.io/gh/apache/shardingsphere/pull/22960/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22960: Table mode cannot be verified by automatic sharding algorithm

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #22960:
URL: https://github.com/apache/shardingsphere/pull/22960#discussion_r1056822592


##########
features/sharding/distsql/handler/src/test/java/org/apache/shardingsphere/sharding/distsql/fixture/sharding/HintInlineShardingAlgorithmFixture.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.distsql.fixture.sharding;
+
+import com.google.common.base.Preconditions;
+import groovy.lang.Closure;
+import groovy.util.Expando;
+import lombok.Getter;
+import org.apache.shardingsphere.infra.util.expr.InlineExpressionParser;
+import org.apache.shardingsphere.sharding.api.sharding.hint.HintShardingAlgorithm;
+import org.apache.shardingsphere.sharding.api.sharding.hint.HintShardingValue;
+
+import java.util.Collection;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+/**
+ * Hint inline sharding algorithm.
+ */
+public final class HintInlineShardingAlgorithmFixture implements HintShardingAlgorithm<Comparable<?>> {
+    
+    private static final String ALGORITHM_EXPRESSION_KEY = "algorithm-expression";
+    
+    private static final String DEFAULT_ALGORITHM_EXPRESSION = "${value}";
+    
+    private static final String HINT_INLINE_VALUE_PROPERTY_NAME = "value";
+    
+    @Getter
+    private Properties props = new Properties();
+    
+    private String algorithmExpression;
+    
+    @Override
+    public void init(final Properties props) {
+        this.props = props;
+        algorithmExpression = getAlgorithmExpression(props);
+    }
+    
+    private String getAlgorithmExpression(final Properties props) {
+        String algorithmExpression = props.getProperty(ALGORITHM_EXPRESSION_KEY, DEFAULT_ALGORITHM_EXPRESSION);
+        Preconditions.checkNotNull(algorithmExpression, "Inline sharding algorithm expression can not be null.");
+        return InlineExpressionParser.handlePlaceHolder(algorithmExpression.trim());
+    }
+    
+    @Override
+    public Collection<String> doSharding(final Collection<String> availableTargetNames, final HintShardingValue<Comparable<?>> shardingValue) {
+        return shardingValue.getValues().isEmpty() ? availableTargetNames : shardingValue.getValues().stream().map(this::doSharding).collect(Collectors.toList());
+    }
+    
+    private String doSharding(final Comparable<?> shardingValue) {
+        Closure<?> closure = createClosure();
+        closure.setProperty(HINT_INLINE_VALUE_PROPERTY_NAME, shardingValue);
+        return closure.call().toString();
+    }
+    
+    private Closure<?> createClosure() {
+        Closure<?> result = new InlineExpressionParser(algorithmExpression).evaluateClosure().rehydrate(new Expando(), null, null);
+        result.setResolveStrategy(Closure.DELEGATE_ONLY);
+        return result;
+    }
+    
+    @Override
+    public String getType() {
+        return "HINT_INLINE";

Review Comment:
   Sorry for being late, why do we need to add `HINT_INLINE`, `INLINE`, `MOD` algorithms, can the built-in algorithms not be used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang merged pull request #22960: Table mode cannot be verified by automatic sharding algorithm

Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22960:
URL: https://github.com/apache/shardingsphere/pull/22960


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org