You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/10/08 15:30:29 UTC

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on a change in pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly

bdelacretaz commented on a change in pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7#discussion_r501813901



##########
File path: src/main/java/org/apache/sling/graphql/core/schema/RankedSchemaProviders.java
##########
@@ -43,7 +43,7 @@
 @Component(service = RankedSchemaProviders.class)
 public class RankedSchemaProviders implements SchemaProvider {
 
-    final RankedServices<SchemaProvider> providers = new RankedServices<>(Order.ASCENDING);
+    final RankedServices<SchemaProvider> providers = new RankedServices<>(Order.DESCENDING);

Review comment:
       Could you just add a comment here that before this commit the order was the opposite?
   I don't think it will break anything, but just in case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org