You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by njayaram2 <gi...@git.apache.org> on 2018/08/23 04:09:11 UTC
[GitHub] madlib pull request #314: Ubuntu support: Enable creation of gppkg on Ubuntu
GitHub user njayaram2 opened a pull request:
https://github.com/apache/madlib/pull/314
Ubuntu support: Enable creation of gppkg on Ubuntu
This commit makes necessary changes to create a gppkg on Ubuntu. The
default behavior when MADlib is built on Ubuntu is to create a .deb
installer. If we want to create a gppkg, then we need an RPM due to
limitations in gppkg. We now create an RPM on Ubuntu (assuming package
alien is installed on Ubuntu) if the right cmake flag is specified. Once
an RPM is created on `make package`, we can now go ahead and create the
gppkg using `make gppkg`.
The cmake flag to use if we want to create an .rpm instead of .deb on
Ubuntu when we run `make package` is:
-DCREATE_RPM_FOR_UBUNTU=True
Co-authored-by: Orhan Kislal <ok...@pivotal.io>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib ubuntu-gppkg-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #314
----
commit bd85bae33473e697d7c26fdac9ee3253ff9a82b3
Author: Nandish Jayaram <nj...@...>
Date: 2018-08-06T22:19:18Z
Ubuntu support: Enable creation of gppkg on Ubuntu
This commit makes necessary changes to create a gppkg on Ubuntu. The
default behavior when MADlib is built on Ubuntu is to create a .deb
installer. If we want to create a gppkg, then we need an RPM due to
limitations in gppkg. We now create an RPM on Ubuntu (assuming package
alien is installed on Ubuntu) if the right cmake flag is specified. Once
an RPM is created on `make package`, we can now go ahead and create the
gppkg using `make gppkg`.
The cmake flag to use if we want to create an .rpm instead of .deb on
Ubuntu when we run `make package` is:
-DCREATE_RPM_FOR_UBUNTU=True
Co-authored-by: Orhan Kislal <ok...@pivotal.io>
----
---
[GitHub] madlib pull request #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/314
---
[GitHub] madlib issue #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Posted by njayaram2 <gi...@git.apache.org>.
Github user njayaram2 commented on the issue:
https://github.com/apache/madlib/pull/314
Thank you for the comments @reductionista , I have updated the comment. Please do have a look at it.
---
[GitHub] madlib issue #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Posted by reductionista <gi...@git.apache.org>.
Github user reductionista commented on the issue:
https://github.com/apache/madlib/pull/314
Also: a user who downloads the madlib gppkg for Ubuntu must install Alien first, before running gppkg -i on it.
---
[GitHub] madlib issue #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Posted by fmcquillan99 <gi...@git.apache.org>.
Github user fmcquillan99 commented on the issue:
https://github.com/apache/madlib/pull/314
Thanks @njayaram2 for the clarification.
---
[GitHub] madlib pull request #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Posted by reductionista <gi...@git.apache.org>.
Github user reductionista commented on a diff in the pull request:
https://github.com/apache/madlib/pull/314#discussion_r213063053
--- Diff: deploy/CMakeLists.txt ---
@@ -27,9 +26,21 @@ elseif(UNIX)
)
elseif(IS_DEBIAN)
message(STATUS "Detected Debian version ${DEB_VERSION}")
- list(APPEND CPACK_GENERATOR
- DEB
- )
+ # -- If cmake flag -DCREATE_RPM_FOR_UBUNTU is set to some
+ # value, then we will create an RPM on Ubuntu. If that
+ # flag is not set to any value in cmake, then we create
+ # only .deb artifact on Ubuntu.
+ # Note that package alien must already be installed for
+ # building an RPM on Ubuntu.
+ if(CREATE_RPM_FOR_UBUNTU)
--- End diff --
The comment makes it sound as if setting -DCREATE_RPM_FOR_UBUNTU would build both .rpm and .deb while not setting it "only" builds .deb.
But looking at the code itself, only one or the other is built but never both. Assuming this is intentional, I would suggest removing "only" from the comment for clarity.
---
[GitHub] madlib issue #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Posted by njayaram2 <gi...@git.apache.org>.
Github user njayaram2 commented on the issue:
https://github.com/apache/madlib/pull/314
@fmcquillan99 It would require alien only if you want to build an rpm on Ubuntu. If you just want to build regular .deb package, we wouldn't need alien.
And alien is neither bundled with MADlib, nor is it automatically downloaded. At the moment, a developers who want to build an rpm on Ubuntu will have to set up their Ubuntu environment with alien.
---
[GitHub] madlib issue #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/314
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/657/
---
[GitHub] madlib pull request #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Posted by reductionista <gi...@git.apache.org>.
Github user reductionista commented on a diff in the pull request:
https://github.com/apache/madlib/pull/314#discussion_r213069972
--- Diff: deploy/CMakeLists.txt ---
@@ -27,9 +26,21 @@ elseif(UNIX)
)
elseif(IS_DEBIAN)
message(STATUS "Detected Debian version ${DEB_VERSION}")
- list(APPEND CPACK_GENERATOR
- DEB
- )
+ # -- If cmake flag -DCREATE_RPM_FOR_UBUNTU is set to some
+ # value, then we will create an RPM on Ubuntu. If that
+ # flag is not set to any value in cmake, then we create
+ # only .deb artifact on Ubuntu.
+ # Note that package alien must already be installed for
--- End diff --
The comment makes it sound as if setting -DCREATE_RPM_FOR_UBUNTU would build both .rpm and .deb while not setting it "only" builds .deb.
But looking at the code itself, only one or the other is built but never both. Assuming this is intentional, I would suggest removing "only" from the comment for clarity.
---
[GitHub] madlib issue #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/314
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/658/
---
[GitHub] madlib issue #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Posted by fmcquillan99 <gi...@git.apache.org>.
Github user fmcquillan99 commented on the issue:
https://github.com/apache/madlib/pull/314
So this requires Alien, but we do not automatically download or bundle Alien, correct?
---