You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/22 20:41:00 UTC

[GitHub] [airflow] dstandish commented on a diff in pull request #22607: Enable use of custom conn extra fields without prefix

dstandish commented on code in PR #22607:
URL: https://github.com/apache/airflow/pull/22607#discussion_r856554326


##########
tests/core/test_providers_manager.py:
##########
@@ -142,6 +145,49 @@ def test_connection_form_widgets(self):
         connections_form_widgets = list(provider_manager.connection_form_widgets.keys())
         assert len(connections_form_widgets) > 29
 
+    @pytest.mark.parametrize(
+        'scenario',
+        [
+            'prefix',
+            'no_prefix',
+            'both_1',
+            'both_2',
+        ],
+    )
+    def test_connection_form__add_widgets_prefix_backcompat(self, scenario):
+        """
+        When field name prefixed, the field name should be used as is.
+        When not prefixed, we should add the prefix defived using the conn type.

Review Comment:
   haha



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org