You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/24 12:18:53 UTC

[GitHub] [spark] Bidek56 commented on a change in pull request #34371: [SPARK-37091][R] SystemRequirements to include Java < 18

Bidek56 commented on a change in pull request #34371:
URL: https://github.com/apache/spark/pull/34371#discussion_r735110357



##########
File path: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala
##########
@@ -94,6 +94,8 @@ class ConfigEntrySuite extends SparkFunSuite {
     assert(conf.get(bytes) === 1024L)
     conf.set(bytes.key, "1k")
     assert(conf.get(bytes) === 1L)
+    conf.set(bytes.key, "2048")
+    assert(conf.get(bytes) === 2048)

Review comment:
       I have reverted the rebase but I think the build issue will be fixed by this [PR](https://github.com/apache/spark/pull/34373)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org