You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/05/04 09:21:33 UTC
[GitHub] ivankelly commented on a change in pull request #1389: Add smoke
tests for LedgerHandleAdv and TailingReads
ivankelly commented on a change in pull request #1389: Add smoke tests for LedgerHandleAdv and TailingReads
URL: https://github.com/apache/bookkeeper/pull/1389#discussion_r186028582
##########
File path: tests/integration/smoke/src/test/java/org/apache/bookkeeper/tests/integration/TestSmoke.java
##########
@@ -48,42 +55,143 @@
private String currentVersion = System.getProperty("currentVersion");
@Before
Review comment:
These could be beforeClass and afterClass, since there's no need to have a clean cluster for the different api tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services