[GitHub] [incubator-druid] leventov commented on issue #7858: Turn ImmutableDruidDataSource into a data container

[GitBox <gi...@apache.org>]

leventov commented on issue #7858: Turn ImmutableDruidDataSource into a data container
URL: https://github.com/apache/incubator-druid/issues/7858#issuecomment-502700077
 
 
   What can also be done is adding static analysis checks to catching calling `ImmutableDruidDataSource.equals()` calls statically rather than in runtime: see https://github.com/apache/incubator-druid/issues/6358#issuecomment-489102183. You can prohibit `$x$.equals()` when the type of `$x$` is `ImmutableDruidDataSource`, as well as `$MapType$<ImmutableDruidDataSource, $ValueType$>` where `$MapType$` is `.*Map` (i. e. `HashMap`, `TreeMap`, etc.), and also similar for `$SetType$<ImmutableDruidDataSource>`.
   
   The error message can say e. g. `"ImmutableDruidDataSource shouldn't be used as the key in containers"`. On the source code level, there should be a link to this issue for the explanation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org