[GitHub] [iceberg] nastra commented on a diff in pull request #7872: Dell,Arrow : Migrating test cases in dell,arrow packages to junit5

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7872:
URL: https://github.com/apache/iceberg/pull/7872#discussion_r1236776255


##########
dell/src/test/java/org/apache/iceberg/dell/mock/ecs/MockS3Client.java:
##########
@@ -93,6 +93,8 @@
 import org.apache.iceberg.relocated.com.google.common.io.ByteStreams;
 import org.junit.Assert;

Review Comment:
   this is still using Junit4's `Assert`



##########
dell/src/test/java/org/apache/iceberg/dell/ecs/TestEcsSeekableInputStream.java:
##########
@@ -27,6 +27,8 @@
 import org.junit.ClassRule;
 import org.junit.Test;

Review Comment:
   this is still using Junit4 tests and hasn't been moved to Junit5



##########
dell/src/test/java/org/apache/iceberg/dell/ecs/TestPropertiesSerDesUtil.java:
##########
@@ -20,8 +20,8 @@
 
 import java.util.Map;
 import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;

Review Comment:
   please use AssertJ assertions. See also https://iceberg.apache.org/contribute/#assertj



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org