You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Rutherglen (JIRA)" <ji...@apache.org> on 2009/02/20 18:37:01 UTC
[jira] Created: (LUCENE-1546) Add
IndexReader.flush/close(commitUserData)
Add IndexReader.flush/close(commitUserData)
-------------------------------------------
Key: LUCENE-1546
URL: https://issues.apache.org/jira/browse/LUCENE-1546
Project: Lucene - Java
Issue Type: Improvement
Components: Index
Affects Versions: 2.4
Reporter: Jason Rutherglen
Fix For: 2.9
IndexWriter offers a commit(String commitUserData) method.
IndexReader can commit as well using the flush/close methods and so
needs an analogous method that accepts commitUserData.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1546) Add
IndexReader.flush/close(commitUserData)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-1546:
------------------------------------------
Assignee: Michael McCandless
> Add IndexReader.flush/close(commitUserData)
> -------------------------------------------
>
> Key: LUCENE-1546
> URL: https://issues.apache.org/jira/browse/LUCENE-1546
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1546.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> IndexWriter offers a commit(String commitUserData) method.
> IndexReader can commit as well using the flush/close methods and so
> needs an analogous method that accepts commitUserData.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1546) Add IndexReader.flush(commitUserData)
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated LUCENE-1546:
-------------------------------------
Summary: Add IndexReader.flush(commitUserData) (was: Add IndexReader.flush/close(commitUserData))
> Add IndexReader.flush(commitUserData)
> -------------------------------------
>
> Key: LUCENE-1546
> URL: https://issues.apache.org/jira/browse/LUCENE-1546
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1546.patch, LUCENE-1546.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> IndexWriter offers a commit(String commitUserData) method.
> IndexReader can commit as well using the flush/close methods and so
> needs an analogous method that accepts commitUserData.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1546) Add
IndexReader.flush/close(commitUserData)
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated LUCENE-1546:
-------------------------------------
Attachment: LUCENE-1546.patch
All tests pass.
- Added IndexReader.flush(userCommitData). I'm hesitant about adding
IR.close(userCommitData) as IndexWriter.close doesn't have a similar
method.
> Add IndexReader.flush/close(commitUserData)
> -------------------------------------------
>
> Key: LUCENE-1546
> URL: https://issues.apache.org/jira/browse/LUCENE-1546
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Fix For: 2.9
>
> Attachments: LUCENE-1546.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> IndexWriter offers a commit(String commitUserData) method.
> IndexReader can commit as well using the flush/close methods and so
> needs an analogous method that accepts commitUserData.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1546) Add
IndexReader.flush(commitUserData)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1546.
----------------------------------------
Resolution: Fixed
Committed revision 748493. Thanks Jason!
> Add IndexReader.flush(commitUserData)
> -------------------------------------
>
> Key: LUCENE-1546
> URL: https://issues.apache.org/jira/browse/LUCENE-1546
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1546.patch, LUCENE-1546.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> IndexWriter offers a commit(String commitUserData) method.
> IndexReader can commit as well using the flush/close methods and so
> needs an analogous method that accepts commitUserData.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1546) Add
IndexReader.flush/close(commitUserData)
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated LUCENE-1546:
-------------------------------------
Priority: Trivial (was: Major)
> Add IndexReader.flush/close(commitUserData)
> -------------------------------------------
>
> Key: LUCENE-1546
> URL: https://issues.apache.org/jira/browse/LUCENE-1546
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1546.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> IndexWriter offers a commit(String commitUserData) method.
> IndexReader can commit as well using the flush/close methods and so
> needs an analogous method that accepts commitUserData.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1546) Add IndexReader.flush(commitUserData)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-1546:
----------------------------------
Attachment: LUCENE-1546-deprecation.patch
This patch fixes deprecation errors:
I wrote a class extends FilterIndexReader. This class produced on compilation an deprecation warning on doCommit() without any hint to this method in my code (I did not implement doCommit nor used the method).
It seems, that javac from 1.5 needs the deprecation also in the subclasses. With this patch applied, the own subclass did not produce the warning anymore.
> Add IndexReader.flush(commitUserData)
> -------------------------------------
>
> Key: LUCENE-1546
> URL: https://issues.apache.org/jira/browse/LUCENE-1546
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1546-deprecation.patch, LUCENE-1546.patch, LUCENE-1546.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> IndexWriter offers a commit(String commitUserData) method.
> IndexReader can commit as well using the flush/close methods and so
> needs an analogous method that accepts commitUserData.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1546) Add
IndexReader.flush(commitUserData)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696803#action_12696803 ]
Michael McCandless commented on LUCENE-1546:
--------------------------------------------
OK I just committed that, thanks Uwe.
> Add IndexReader.flush(commitUserData)
> -------------------------------------
>
> Key: LUCENE-1546
> URL: https://issues.apache.org/jira/browse/LUCENE-1546
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1546-deprecation.patch, LUCENE-1546.patch, LUCENE-1546.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> IndexWriter offers a commit(String commitUserData) method.
> IndexReader can commit as well using the flush/close methods and so
> needs an analogous method that accepts commitUserData.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1546) Add
IndexReader.flush/close(commitUserData)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1546:
---------------------------------------
Attachment: LUCENE-1546.patch
I tweaked the patch to keep back compat (we can't just change IndexReader's protected doCommit() method). I think it's ready to commit... I'll wait a day or two.
> Add IndexReader.flush/close(commitUserData)
> -------------------------------------------
>
> Key: LUCENE-1546
> URL: https://issues.apache.org/jira/browse/LUCENE-1546
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1546.patch, LUCENE-1546.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> IndexWriter offers a commit(String commitUserData) method.
> IndexReader can commit as well using the flush/close methods and so
> needs an analogous method that accepts commitUserData.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org