You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/05 09:26:43 UTC

[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4758: vmware: fix stopped VM volume migration

harikrishna-patnala commented on a change in pull request #4758:
URL: https://github.com/apache/cloudstack/pull/4758#discussion_r588150811



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -2683,15 +2683,14 @@ public Answer deleteVolume(DeleteCommand cmd) {
                         List<VirtualDisk> virtualDisks = vmMo.getVirtualDisks();
                         List<String> managedDatastoreNames = getManagedDatastoreNamesFromVirtualDisks(virtualDisks);
 
+                        // Preserve other disks of the VM

Review comment:
       Thanks for these changes @shwstppr. 
   Can you please test destroy VM and expunge VM cases with VM having disks. Because this particular block is removed to address disk detachments in case of destroy VM. If those operations are not effected, this looks good to me.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org