You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/06 18:10:18 UTC
[GitHub] [spark] ueshin opened a new pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
ueshin opened a new pull request #32069:
URL: https://github.com/apache/spark/pull/32069
### What changes were proposed in this pull request?
Now that we merged the Koalas main code into PySpark code base (#32036), we should enable doctests on the Spark's infrastructure.
### Why are the changes needed?
Currently the pandas-on-Spark module is not testes at all.
We should enable doctests first, and we will port other unit tests separately later.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Enabled the whole doctests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814370096
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41540/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814551115
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41553/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814371203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814530251
**[Test build #136976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136976/testReport)** for PR 32069 at commit [`2651cfb`](https://github.com/apache/spark/commit/2651cfb83ccdbf871bcf1d5bc05df9b237e3b493).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814530251
**[Test build #136976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136976/testReport)** for PR 32069 at commit [`2651cfb`](https://github.com/apache/spark/commit/2651cfb83ccdbf871bcf1d5bc05df9b237e3b493).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814332407
**[Test build #136963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136963/testReport)** for PR 32069 at commit [`06635fa`](https://github.com/apache/spark/commit/06635fa78c2f8f2455157e4462bd9a9f5528eee7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814548463
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136968/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814587502
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136976/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814490857
**[Test build #136968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136968/testReport)** for PR 32069 at commit [`dd1e366`](https://github.com/apache/spark/commit/dd1e3660fbb94bdc21d20f14b3de4b0981105dce).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814418011
**[Test build #136964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136964/testReport)** for PR 32069 at commit [`e86ce1b`](https://github.com/apache/spark/commit/e86ce1bfa47938056fc5e36cba32f34a6d1cad20).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814548463
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136968/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814490857
**[Test build #136968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136968/testReport)** for PR 32069 at commit [`dd1e366`](https://github.com/apache/spark/commit/dd1e3660fbb94bdc21d20f14b3de4b0981105dce).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814440723
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136964/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814512218
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41545/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814551094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814371235
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41541/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814537775
**[Test build #136968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136968/testReport)** for PR 32069 at commit [`dd1e366`](https://github.com/apache/spark/commit/dd1e3660fbb94bdc21d20f14b3de4b0981105dce).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814332446
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136963/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32069:
URL: https://github.com/apache/spark/pull/32069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814332446
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136963/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814512218
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41545/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814371235
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41541/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814332407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814587502
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136976/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814340045
**[Test build #136964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136964/testReport)** for PR 32069 at commit [`e86ce1b`](https://github.com/apache/spark/commit/e86ce1bfa47938056fc5e36cba32f34a6d1cad20).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814340045
**[Test build #136964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136964/testReport)** for PR 32069 at commit [`e86ce1b`](https://github.com/apache/spark/commit/e86ce1bfa47938056fc5e36cba32f34a6d1cad20).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814370096
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41540/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814512192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814551115
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41553/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #32069:
URL: https://github.com/apache/spark/pull/32069#discussion_r608259435
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -161,6 +161,8 @@ jobs:
pyspark-sql, pyspark-mllib, pyspark-resource
- >-
pyspark-core, pyspark-streaming, pyspark-ml
+ - >-
+ pyspark-pandas
Review comment:
Maybe we can rebalance the pyspark tests after we finish porting unit tests.
##########
File path: python/pyspark/pandas/frame.py
##########
@@ -3506,7 +3506,7 @@ def style(self) -> "Styler":
Examples
--------
- >>> pp.range(1001).style # doctest: +ELLIPSIS
+ >>> pp.range(1001).style # doctest: +SKIP
Review comment:
`style` needs an optional dependency `Jinja2`.
##########
File path: python/pyspark/pandas/groupby.py
##########
@@ -1894,12 +1894,12 @@ def tail(self, n=5) -> Union[DataFrame, Series]:
... 'b': [2, 3, 1, 4, 6, 9, 8, 10, 7, 5],
... 'c': [3, 5, 2, 5, 1, 2, 6, 4, 3, 6]},
... columns=['a', 'b', 'c'],
- ... index=[7, 2, 4, 1, 3, 4, 9, 10, 5, 6])
+ ... index=[7, 2, 3, 1, 3, 4, 9, 10, 5, 6])
Review comment:
This is to reduce the test flakiness.
##########
File path: python/pyspark/pandas/sql_processor.py
##########
@@ -300,3 +300,33 @@ def _convert_var(self, var) -> Any:
if isinstance(var, (tuple, range)):
return self._convert_var(list(var))
raise ValueError("Unsupported variable type {}: {}".format(type(var).__name__, str(var)))
+
+
+def _test():
+ import os
+ import doctest
+ import sys
+ from pyspark.sql import SparkSession
+ import pyspark.pandas.sql_processor
Review comment:
Renamed the file name from `sql.py` to `sql_processor.py` to avoid the name conflict between `sql` module and `pp.sql` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814440723
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136964/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814850361
Let me merge this. These tests are flaky. All tests passed (considering the preivous runs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814363580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32069: [SPARK-34972][PYTHON] Make pandas-on-Spark doctests work.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32069:
URL: https://github.com/apache/spark/pull/32069#issuecomment-814586381
**[Test build #136976 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136976/testReport)** for PR 32069 at commit [`2651cfb`](https://github.com/apache/spark/commit/2651cfb83ccdbf871bcf1d5bc05df9b237e3b493).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org