[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

[GitBox <gi...@apache.org>]

mimaison commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r490933197



##########
File path: clients/src/main/resources/common/message/ListOffsetResponse.json
##########
@@ -48,7 +48,7 @@
           "about": "The timestamp associated with the returned offset." },
         { "name": "Offset", "type": "int64", "versions": "1+", "default": "-1", "ignorable": false,
           "about": "The returned offset." },
-        { "name": "LeaderEpoch", "type": "int32", "versions": "4+" }
+        { "name": "LeaderEpoch", "type": "int32", "versions": "4+", "default": "-1" }

Review comment:
       Until now, this field is an Optional and it's defaulted to `-1` in https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/requests/RequestUtils.java#L30-L32
   
   Otherwise an `int32` default value is `0` with the generator code




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org