You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/02/02 05:09:59 UTC
[GitHub] [arrow] mapleFU opened a new pull request, #33995: MINOR: [C++][Parquet] Parquet: Some tiny updates on bf
mapleFU opened a new pull request, #33995:
URL: https://github.com/apache/arrow/pull/33995
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
* adding a interface `OptimalNumOfBytes`, because `OptimalNumOfBits` is confusing...
* BloomFilter accept a `MemoryPool` as input argument
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
They're already tested...
### Are there any user-facing changes?
No. (But user may misuse `BloomFilter::Init` previously)
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #33995: GH-34078: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1423158093
> Hi @mapleFU we need a unique issue for each PR. I created #34078 for this one, but I need to you assign yourself to it before I can merge. Could you do that? (For some reason GitHub won't let me.)
Perhaps @mapleFU needs to comment on #34078 before you can assign him.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on a diff in pull request #33995: GH-15164: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #33995:
URL: https://github.com/apache/arrow/pull/33995#discussion_r1098505376
##########
cpp/src/parquet/bloom_filter.h:
##########
@@ -36,7 +36,7 @@ class PARQUET_EXPORT BloomFilter {
public:
// Maximum Bloom filter size, it sets to HDFS default block size 128MB
// This value will be reconsidered when implementing Bloom filter producer.
- static constexpr uint32_t kMaximumBloomFilterBytes = 128 * 1024 * 1024;
+ static constexpr uint64_t kMaximumBloomFilterBytes = 128 * 1024 * 1024;
Review Comment:
Currently just keep it uint32_t is ok, since it could support 4G. For `Bits`, its 1G Bytes, and it's 8 times greater than `kMaximumBloomFilterBytes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #33995: GH-15164: [C++][Parquet] Some tiny updates on bf
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1413339579
* Closes: #15164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #33995: GH-34078: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1423500978
I've taken the issue now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #33995: GH-15164: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1418052201
Oh, seems https://github.com/apache/arrow/pull/34038 cause the error... Let's waiting it to be merged...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #33995: GH-15164: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1418024003
No idea why these two tests still failed... The error messages are to confusing for me...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #33995: MINOR: [C++][Parquet] Some tiny updates on bf
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1413185424
Could you open a new issue for this?
See also our "MINOR" definition: https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#minor-fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #33995: GH-15164: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1413424619
That's my fault. I didn't add `explicit` after add an ctor argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #33995: GH-15164: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1413410392
@mapleFU Can you take a look at the CI failures? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #33995: GH-34078: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1423069640
Hi @mapleFU we need a unique issue for each PR. I created https://github.com/apache/arrow/issues/34078 for this one, but I need to you assign yourself to it before I can merge. Could you do that? (For some reason GitHub won't let me.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #33995: MINOR: [C++][Parquet] Parquet: Some tiny updates on bf
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1413159762
@pitrou @wjones127 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #33995: GH-34078: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1423066623
:warning: GitHub issue #34078 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #33995: GH-34078: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1423066572
* Closes: #34078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 merged pull request #33995: GH-34078: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 merged PR #33995:
URL: https://github.com/apache/arrow/pull/33995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #33995: GH-15164: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1421028203
@pitrou Seems all tests passed, mind take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #33995: GH-34078: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1423066648
:warning: GitHub issue #34078 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #33995: GH-34078: [C++][Parquet] Minor API improvements for BloomFilter
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #33995:
URL: https://github.com/apache/arrow/pull/33995#issuecomment-1425124004
Benchmark runs are scheduled for baseline = 9cb6fd66418c102530e7b40c22c61f03d0d6de98 and contender = d512dd2e886037b6a8757089a922a49dd3b52a4b. d512dd2e886037b6a8757089a922a49dd3b52a4b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0ec7f6ae32bf4925a100545508b6e3fd...1b2bd9cb28ec407c95ae0a5166cedd08/)
[Failed :arrow_down:0.52% :arrow_up:0.06%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/293e61ed15334049a5bde48c030e7f76...275e15b378584870a66413b4b87cf293/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8136600c99d64806b778a446d5f18b75...db480355e6b749e8b2a75d8dfbd40d1b/)
[Finished :arrow_down:0.22% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8d4cf3b81ef8406fbf421545e9964259...ed4c1c4d734b4035aa68848f8c6cc0b8/)
Buildkite builds:
[Finished] [`d512dd2e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2354)
[Finished] [`d512dd2e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2382)
[Finished] [`d512dd2e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2352)
[Finished] [`d512dd2e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2373)
[Finished] [`9cb6fd66` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2353)
[Failed] [`9cb6fd66` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2381)
[Finished] [`9cb6fd66` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2351)
[Finished] [`9cb6fd66` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2372)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on a diff in pull request #33995: MINOR: [C++][Parquet] Parquet: Some tiny updates on bf
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #33995:
URL: https://github.com/apache/arrow/pull/33995#discussion_r1094043826
##########
cpp/src/parquet/bloom_filter.h:
##########
@@ -36,7 +36,7 @@ class PARQUET_EXPORT BloomFilter {
public:
// Maximum Bloom filter size, it sets to HDFS default block size 128MB
// This value will be reconsidered when implementing Bloom filter producer.
- static constexpr uint32_t kMaximumBloomFilterBytes = 128 * 1024 * 1024;
+ static constexpr uint64_t kMaximumBloomFilterBytes = 128 * 1024 * 1024;
Review Comment:
Should the return type of `OptimalNumOfBits` be changed to uint64_t as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org