You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/25 20:35:54 UTC
[GitHub] [airflow] pingzh opened a new pull request #22535: Pass X-Trino-Client-Info in trino hook
pingzh opened a new pull request #22535:
URL: https://github.com/apache/airflow/pull/22535
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
so that in the trino side, it can track back to an airflow task
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on pull request #22535: Pass X-Trino-Client-Info in trino hook
Posted by GitBox <gi...@apache.org>.
pingzh commented on pull request #22535:
URL: https://github.com/apache/airflow/pull/22535#issuecomment-1079415434
@eladkal please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22535: Pass X-Trino-Client-Info in trino hook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22535:
URL: https://github.com/apache/airflow/pull/22535#issuecomment-1079419794
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SamWheating commented on a change in pull request #22535: Pass X-Trino-Client-Info in trino hook
Posted by GitBox <gi...@apache.org>.
SamWheating commented on a change in pull request #22535:
URL: https://github.com/apache/airflow/pull/22535#discussion_r835797358
##########
File path: airflow/providers/trino/hooks/trino.py
##########
@@ -82,12 +111,15 @@ def get_conn(self) -> Connection:
delegate=_boolify(extra.get('kerberos__delegate', False)),
ca_bundle=extra.get('kerberos__ca_bundle'),
)
+
+ http_headers = {"X-Trino-Client-Info": generate_trino_client_info()}
Review comment:
The `X-Trino` header prefix has been configurable since Trino was rebranded from PrestoSQL:
https://trino.io/docs/current/admin/properties-general.html?highlight=headers#protocol-v1-alternate-header-name
Do you think that its worth supporting the same kind of override here? If a user has overriden the default header prefix then this hardcoded value of `X-Trino-Client-Info` won't get properly picked up or displayed in the Trino UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #22535: Pass X-Trino-Client-Info in trino hook
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #22535:
URL: https://github.com/apache/airflow/pull/22535#discussion_r835808116
##########
File path: airflow/providers/trino/hooks/trino.py
##########
@@ -82,12 +111,15 @@ def get_conn(self) -> Connection:
delegate=_boolify(extra.get('kerberos__delegate', False)),
ca_bundle=extra.get('kerberos__ca_bundle'),
)
+
+ http_headers = {"X-Trino-Client-Info": generate_trino_client_info()}
Review comment:
I'm OK with not supporting it.
Users of older versions can overide the function and have whatever custom behavior they need to support older versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #22535: Pass X-Trino-Client-Info in trino hook
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #22535:
URL: https://github.com/apache/airflow/pull/22535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org