or just remove them and set the style info in the BODY element in the css file
Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
----------------------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-588
URL: https://issues.apache.org/jira/browse/OFBIZ-588
Project: Apache OFBiz (The Open for Business Project)
Issue Type: Sub-task
Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
Reporter: Jacopo Cappellato
Priority: Minor
all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by Ashish Vijaywargiya <as...@adititechlabs.com>.
Ooops........I misunderstood the task. Thanks Chris for your help. I will take care of this and will send the patch for this ASAP. Can any of the committer please remove my all the previous patch ??? On 1/6/07, Chris Howe (JIRA) <ji...@apache.org> wrote: > > > [ > https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462665] > > Chris Howe commented on OFBIZ-588: > ---------------------------------- > > Ashish, > > Thank you for taking an interest in this! > > The description for this issue is not saying to replace all <div > class="tabletext"> with <p>. It's saying to simply remove all <div > class="tabletext">. > > So, generally when you're dealing with styling for form input, just remove > the <div class="tabletext"> and the closing </div> for it. > > The exception to this is when a tabletext div is being used like a > paragraph, to replace it with <p>. An example of this situation is on the > webtools main page when you're not logged in. The text: > > > << > << > For something interesting make sure you are logged in, try username:admin, > password:ofbiz. > > The purpose of this Web Tools administration package is to contain all of > the administration tools that directly relate to the various Core Tool > Components. The Core Tool Component layer is defined in the architecture > documents as the container of all entity definitions shared by the vertical > applications that are built on top of these entity definitions and the tools > surrounding them such as the entity, workflow, and rule engines, content and > knowledge management, data analysis, and so forth. > > This application is primarily intended for developers and system > administrators. > NOTE: If you have not already run the installation data loading script, > from the ofbiz home directory run "ant run-install" or "java -jar > ofbiz.jar install" > > >> > >> > > This part should be encapsulated with a <p> </p> instead of <div > class="tabletext"></div> > > > Replace all div class="tabletext" wrappers with <p> or just remove them > and set the style info in the BODY element in the css file > > > ---------------------------------------------------------------------------------------------------------------------------------- > > > > Key: OFBIZ-588 > > URL: https://issues.apache.org/jira/browse/OFBIZ-588 > > Project: Apache OFBiz (The Open for Business Project) > > Issue Type: Sub-task > > Components: accounting, content, ecommerce, framework, > hhfacility, humanres, manufacturing, marketing, order, party, product, > workeffort > > Reporter: Jacopo Cappellato > > Priority: Minor > > Attachments: Accounting_Jan06.patch, Product_Jan06_Phase1.patch, > WorkEffort_Jan06.patch > > > > > > all <div class="tabletext"> wrappers can be removed, the exception being > where they are used like <p>s - the default text style can be set on body; > > -- > This message is automatically generated by JIRA. > - > If you think it was sent incorrectly contact one of the administrators: > https://issues.apache.org/jira/secure/Administrators.jspa > - > For more information on JIRA, see: http://www.atlassian.com/software/jira > > >
or just remove them and set the style info in the BODY element in the css file Posted by Ashish Vijaywargiya <as...@adititechlabs.com>.
Jacopo, Thanks for your nice reply. First I read Subject of Issue and that was "Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file " So I thought to change the div class="tabletext" into p's. I am sorry for not reading and thinking your details properly and that was "all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;" And now from your's and chris comments I got the idea of what to do. I will submit the patch for this task whenever I will get time. Thanks Jacopo & Chris for your support and once again sorry for my stupid mistake. On 1/6/07, Jacopo Cappellato (JIRA) <ji...@apache.org> wrote: > > > [ > https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462691] > > Jacopo Cappellato commented on OFBIZ-588: > ----------------------------------------- > > Ashish, > > yes Chris is right (and sorry for not being very clear about this task); > however I'm reviewing the patch for the accounting component and it looks > you did the right thing, except for the <div> elements inside table cells > <td> that should be removed and not replaced by <p> tags. > So for example: > > <td><div class="tabletext">some text...</div></td> > should become > <td>some text...</td> > > and > <td><div class="tabletext"><b>ID</b></div></td> > should probably become > <th>ID</th> > (to all: is it correct?) > > Thanks for your great help! > > > -- Regards Ashish Vijaywargiya Aditisoft Technology Laboratory
or just remove them and set the style info in the BODY element in the css file Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462665 ]
Chris Howe commented on OFBIZ-588:
----------------------------------
Ashish,
Thank you for taking an interest in this!
The description for this issue is not saying to replace all <div class="tabletext"> with <p>. It's saying to simply remove all <div class="tabletext">.
So, generally when you're dealing with styling for form input, just remove the <div class="tabletext"> and the closing </div> for it.
The exception to this is when a tabletext div is being used like a paragraph, to replace it with <p>. An example of this situation is on the webtools main page when you're not logged in. The text:
<<
<<
For something interesting make sure you are logged in, try username:admin, password:ofbiz.
The purpose of this Web Tools administration package is to contain all of the administration tools that directly relate to the various Core Tool Components. The Core Tool Component layer is defined in the architecture documents as the container of all entity definitions shared by the vertical applications that are built on top of these entity definitions and the tools surrounding them such as the entity, workflow, and rule engines, content and knowledge management, data analysis, and so forth.
This application is primarily intended for developers and system administrators.
NOTE: If you have not already run the installation data loading script, from the ofbiz home directory run "ant run-install" or "java -jar ofbiz.jar install"
>>
>>
This part should be encapsulated with a <p> </p> instead of <div class="tabletext"></div>
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: Accounting_Jan06.patch, Product_Jan06_Phase1.patch, WorkEffort_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462691 ]
Jacopo Cappellato commented on OFBIZ-588:
-----------------------------------------
Ashish,
yes Chris is right (and sorry for not being very clear about this task); however I'm reviewing the patch for the accounting component and it looks you did the right thing, except for the <div> elements inside table cells <td> that should be removed and not replaced by <p> tags.
So for example:
<td><div class="tabletext">some text...</div></td>
should become
<td>some text...</td>
and
<td><div class="tabletext"><b>ID</b></div></td>
should probably become
<th>ID</th>
(to all: is it correct?)
Thanks for your great help!
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: Accounting_Jan06.patch, Product_Jan06_Phase1.patch, WorkEffort_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462809 ]
Jacopo Cappellato commented on OFBIZ-588:
-----------------------------------------
In general, I'd suggest to use the <th> tags everywhere in place of:
<td><div class="tabletext"><b>ID</b></div></td>
or
<td><div class="tableheadtext">ID</div></td>
We will eventually refine this as a second task after this first one is completed.
Is ti ok?
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: Accounting_Jan06.patch, Product_Jan06_Phase1.patch, WorkEffort_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461996 ]
Anil K Patel commented on OFBIZ-588:
------------------------------------
I can take up WorkEffort and Accounting. I know this is real simple but still Can you give us a reference to a file that can show what exactly needs to be done.
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya updated OFBIZ-588:
--------------------------------------
Attachment: WorkEffort_Jan06.patch
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: Accounting_Jan06.patch, WorkEffort_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462692 ]
Chris Howe commented on OFBIZ-588:
----------------------------------
>>
<td><div class="tabletext"><b>ID</b></div></td>
should probably become
<th>ID</th>
(to all: is it correct?)
<<
It's often times correct.
<th> is for table header. For instance when you have tabular data, the cells for the header row should be <th>
However, many of the forms that have <b> in them are the equivalents of the "single" type form from the form widget. These should (depending on the pattern OFBiz would like to adopt) use a <label></label> tag inside the <td></td>.
http://www.w3.org/TR/html4/interact/forms.html#h-17.9
These should not use the <th> tag, as it makes styling the single form very difficult using the same css for tabular data.
As there are varying opinions on the "correct" way to do html in concert with css, one could certainly have the opinion that the <label> tag shouldn't be used, but I think that same logic would dictate that there is no need to change the current tabletext pattern. I personally have no opinion on this either way as long as it was consistent.
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: Accounting_Jan06.patch, Product_Jan06_Phase1.patch, WorkEffort_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya updated OFBIZ-588:
--------------------------------------
Attachment: Accounting_Jan06.patch
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: Accounting_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya updated OFBIZ-588:
--------------------------------------
Attachment: Product_Jan06_Phase1.patch
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: Accounting_Jan06.patch, Product_Jan06_Phase1.patch, WorkEffort_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462004 ]
Anil K Patel commented on OFBIZ-588:
------------------------------------
I see it in svn, So clean up mentioned in this task and related other task for these two component.
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462656 ]
Ashish Vijaywargiya commented on OFBIZ-588:
-------------------------------------------
Hi,
This patch(i.e Product) was getting bigger So I though to split it into two parts.
I will attach Next part ASAP.
Regards
Ashish Vijaywargiya
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: Accounting_Jan06.patch, Product_Jan06_Phase1.patch, WorkEffort_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462608 ]
Ashish Vijaywargiya commented on OFBIZ-588:
-------------------------------------------
Jacopo,
I thought to reduce some of your work :-)
So here is the First Accounting patch in this direction.
I'll send the patches for other component ASAP.
Regards
Ashish Vijaywargiya
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: Accounting_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
or just remove them and set the style info in the BODY element in the css file Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462836 ]
Chris Howe commented on OFBIZ-588:
----------------------------------
That should be fine as it appears the change makes it indistinguishable from the current styling and that the current tags don't have the benefit of semantically describing their content either.
> Replace all div class="tabletext" wrappers with <p> or just remove them and set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-588
> URL: https://issues.apache.org/jira/browse/OFBIZ-588
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: accounting, content, ecommerce, framework, hhfacility, humanres, manufacturing, marketing, order, party, product, workeffort
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: Accounting_Jan06.patch, Product_Jan06_Phase1.patch, WorkEffort_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira