You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dh...@apache.org on 2017/01/03 17:57:59 UTC
[1/2] beam git commit: WriteTest: use ToString#element()
Repository: beam
Updated Branches:
refs/heads/master 70ff6bfd9 -> 467e38596
WriteTest: use ToString#element()
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/0d0e6d19
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/0d0e6d19
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/0d0e6d19
Branch: refs/heads/master
Commit: 0d0e6d19528392021c9972939d80123827df15db
Parents: 70ff6bf
Author: Dan Halperin <dh...@google.com>
Authored: Fri Dec 30 03:53:44 2016 -0800
Committer: Dan Halperin <dh...@google.com>
Committed: Tue Jan 3 09:57:40 2017 -0800
----------------------------------------------------------------------
.../src/test/java/org/apache/beam/sdk/io/WriteTest.java | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/0d0e6d19/sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteTest.java
index 79f4c4b..2cea72c 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteTest.java
@@ -59,6 +59,7 @@ import org.apache.beam.sdk.transforms.MapElements;
import org.apache.beam.sdk.transforms.PTransform;
import org.apache.beam.sdk.transforms.ParDo;
import org.apache.beam.sdk.transforms.SimpleFunction;
+import org.apache.beam.sdk.transforms.ToString;
import org.apache.beam.sdk.transforms.display.DisplayData;
import org.apache.beam.sdk.transforms.windowing.FixedWindows;
import org.apache.beam.sdk.transforms.windowing.Sessions;
@@ -296,7 +297,7 @@ public class WriteTest {
@Test
public void testWriteUnbounded() {
PCollection<String> unbounded = p.apply(CountingInput.unbounded())
- .apply(MapElements.via(new ToStringFn()));
+ .apply(ToString.<Long>element());
TestSink sink = new TestSink();
thrown.expect(IllegalArgumentException.class);
@@ -304,13 +305,6 @@ public class WriteTest {
unbounded.apply(Write.to(sink));
}
- private static class ToStringFn extends SimpleFunction<Long, String> {
- @Override
- public String apply(Long input) {
- return Long.toString(input);
- }
- }
-
/**
* Performs a Write transform and verifies the Write transform calls the appropriate methods on
* a test sink in the correct order, as well as verifies that the elements of a PCollection are
[2/2] beam git commit: This closes #1720
Posted by dh...@apache.org.
This closes #1720
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/467e3859
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/467e3859
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/467e3859
Branch: refs/heads/master
Commit: 467e38596a49544b3735b441db61d24d4a5e4ff5
Parents: 70ff6bf 0d0e6d1
Author: Dan Halperin <dh...@google.com>
Authored: Tue Jan 3 09:57:46 2017 -0800
Committer: Dan Halperin <dh...@google.com>
Committed: Tue Jan 3 09:57:46 2017 -0800
----------------------------------------------------------------------
.../src/test/java/org/apache/beam/sdk/io/WriteTest.java | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
----------------------------------------------------------------------