You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/03/28 01:49:41 UTC
[GitHub] [nifi] walmut opened a new pull request #4167: NIFI-7263 Add [No Tracking] Listing Strategy to ListFile/ListFTP proc…
walmut opened a new pull request #4167: NIFI-7263 Add [No Tracking] Listing Strategy to ListFile/ListFTP proc…
URL: https://github.com/apache/nifi/pull/4167
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Add a new Listing Strategy called [No Tracking] to LisFile/ListFTP. The purpose of this improvement is give a choice to list all files as like as GetFile processor does. As List/Fetch mechanism.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] walmut commented on a change in pull request #4167: NIFI-7263 Add [No Tracking] Listing Strategy to ListFile/ListFTP proc…
Posted by GitBox <gi...@apache.org>.
walmut commented on a change in pull request #4167: NIFI-7263 Add [No Tracking] Listing Strategy to ListFile/ListFTP proc…
URL: https://github.com/apache/nifi/pull/4167#discussion_r401076346
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/AbstractListProcessor.java
##########
@@ -192,12 +192,16 @@
" However additional DistributedMapCache controller service is required and more JVM heap memory is used." +
" See the description of 'Entity Tracking Time Window' property for further details on how it works.");
+ public static final AllowableValue NO_TRACKING = new AllowableValue("none", "No Tracking",
+ "This strategy lists an entity without any tracking. Any property that related to persist state" +
+ " will be disregarded.");
Review comment:
@pvillard31 How about this: "This strategy lists an entity without any tracking. The same entity will be listed each time on executing this processor. It is recommended to change the default run schedule value. Any property that related to the persisting state will be disregarded."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] pvillard31 commented on a change in pull request #4167: NIFI-7263 Add [No Tracking] Listing Strategy to ListFile/ListFTP proc…
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on a change in pull request #4167: NIFI-7263 Add [No Tracking] Listing Strategy to ListFile/ListFTP proc…
URL: https://github.com/apache/nifi/pull/4167#discussion_r400713968
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/AbstractListProcessor.java
##########
@@ -192,12 +192,16 @@
" However additional DistributedMapCache controller service is required and more JVM heap memory is used." +
" See the description of 'Entity Tracking Time Window' property for further details on how it works.");
+ public static final AllowableValue NO_TRACKING = new AllowableValue("none", "No Tracking",
+ "This strategy lists an entity without any tracking. Any property that related to persist state" +
+ " will be disregarded.");
Review comment:
I'd probably try to be even more descriptive here... I think it's worth saying that the same files will be listed at each execution of this processor, and that it's recommended to change the default run schedule value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services