You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alex Petrov (Jira)" <ji...@apache.org> on 2021/05/10 13:11:00 UTC
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java
DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341901#comment-17341901 ]
Alex Petrov commented on CASSANDRA-16649:
-----------------------------------------
Wanted to discuss [this change|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk#diff-b7d8cc9a23d28a1713d5242f83da30838851d0685528abdb937afe7d9b899de6R59] in more details. I think it's a good idea to allow people to test out dtest-api changes using a snapshot, however it seems that allowing people to commit these things to `trunk` might be a bit dangerous, since we won't be able to reproduce the builds. I'm not sure what's the best way to mitigate this though.
Do you plan to address {{rc/beta/alpha}} comparisons in this patch (see [this todo|https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649#diff-871746bc8496d850d8660ffd287e44fcc60c9050e17f12c45ab8c9ece49c3acdR122])?
The rest of the change looks good to me.
> Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-16649
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16649
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/java
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 4.0-rc, 4.x
>
>
> - https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649
> - https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org