[jira] Commented: (MAPREDUCE-856) Localized files from DistributedCache should have right access-control

["Hemanth Yamijala (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750346#action_12750346 ] 

Hemanth Yamijala commented on MAPREDUCE-856:
--------------------------------------------

Looked at the new patch. Some comments:

- If the user directory cannot be created on any disk, we should fail localization. (This is not incorporated)
- Synchronization is still necessary when creating user directories. Consider a case where two tasks from the same user from two different jobs are being localized at the same time. This could cause failures in making the directories etc. Also note that bringing back this synchronization needs to incorporate comments related to synchronization that were raised before.
- The changes in JobClient might cause a regression. Not sure about this. In the old code, the call to getUGI was done in configureCommandLineOptions much early on, with the result that the jobConf parameter was changed to set the hadoop.job.ugi. This conf object is used for other purposes like uploading jar files etc. Would this be a problem in the new code, because this call is now being set much later.
- TestMiniMRWithDFS.checkTaskDirectories seems to be more generic than needed and hence more complicated. For e.g. if we currently don't seem to need multi-user support - so can we drop it. The advantage is that it makes the code simpler. Right now, it seems too generic because it needs to support these generic cases.

> Localized files from DistributedCache should have right access-control
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-856
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-856
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: tasktracker
>            Reporter: Arun C Murthy
>            Assignee: Vinod K V
>         Attachments: MAPREDUCE-856-20090820.txt, MAPREDUCE-856-20090821.txt, MAPREDUCE-856-20090825.3.txt, MAPREDUCE-856-20090827.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.