You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by djvulee <gi...@git.apache.org> on 2017/06/12 12:01:53 UTC
[GitHub] spark pull request #18279: [SPARK-21064][Core][Test] Fix the default value b...
GitHub user djvulee opened a pull request:
https://github.com/apache/spark/pull/18279
[SPARK-21064][Core][Test] Fix the default value bug in NettyBlockTran…
## What changes were proposed in this pull request?
Fix the default value bug in NettyBlockTransferServiceSuite.
The defalut value for `spark.port.maxRetries` is 100, but we use the 10
in the suite file, we change 10 to 100.
## How was this patch tested?
No Test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djvulee/spark branch-2.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18279.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18279
----
commit 5de1790783f07737432f75ef7ed7ea8804fc6b20
Author: DjvuLee <li...@bytedance.com>
Date: 2017-06-12T11:50:02Z
[SPARK-21064][Core][Test] Fix the default value bug in NettyBlockTransferServiceSuite
The defalut value for `spark.port.maxRetries` is 100, but we use the 10
in the suite file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18279: [SPARK-21064][Core][Test] Fix the default value bug in N...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18279
@djvulee this needs to be a pull request vs `master`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18279: [SPARK-21064][Core][Test] Fix the default value bug in N...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18279
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18279: [SPARK-21064][Core][Test] Fix the default value b...
Posted by djvulee <gi...@git.apache.org>.
Github user djvulee closed the pull request at:
https://github.com/apache/spark/pull/18279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18279: [SPARK-21064][Core][Test] Fix the default value bug in N...
Posted by djvulee <gi...@git.apache.org>.
Github user djvulee commented on the issue:
https://github.com/apache/spark/pull/18279
we should port this to master too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18279: [SPARK-21064][Core][Test] Fix the default value bug in N...
Posted by djvulee <gi...@git.apache.org>.
Github user djvulee commented on the issue:
https://github.com/apache/spark/pull/18279
Ok, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18279: [SPARK-21064][Core][Test] Fix the default value bug in N...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18279
@djvulee no, it needs to be merged to master first. Close this and open a PR vs master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org