You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/24 07:49:09 UTC

[GitHub] [iotdb] yschengzi opened a new pull request #4025: [IOTDB-1651]Fix sync error between different os

yschengzi opened a new pull request #4025:
URL: https://github.com/apache/iotdb/pull/4025


   origin from discussion#4001(https://github.com/apache/iotdb/discussions/4001)
   
   if we want to sync one computer with windows os data to another computer with unix os,
   the sync process will stop, and a error is thrown like this:
   
   -receiver/10.20.12.142_0583441c495b416d95c9945631bc3eff/data/root.industry.w9/root.industry.w9\0\0\1631930688647-1-0-0.tsfile, type=ADD}
   java.io.IOException: Can not load new tsfile /data/local/iotdb-server/./sbin/../data/data/sync-receiver/10.20.12.142_0583441c495b416d95c9945631bc3eff/data/root.industry.w9/root.industry.w9\0\0\1631930688647-1-0-0.tsfile
   at org.apache.iotdb.db.sync.receiver.load.FileLoader.loadNewTsfile(FileLoader.java:148)
   at org.apache.iotdb.db.sync.receiver.load.FileLoader.handleLoadTask(FileLoader.java:120)
   at org.apache.iotdb.db.sync.receiver.load.FileLoader.lambda$new$0(FileLoader.java:87)
   at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   at java.lang.Thread.run(Thread.java:748)
   Caused by: org.apache.iotdb.db.exception.StorageEngineException: org.apache.iotdb.db.exception.metadata.IllegalPathException: 10.20.12.142_0583441c495b416d95c9945631bc3eff is not a legal path
   at org.apache.iotdb.db.engine.StorageEngine.getProcessorDirectly(StorageEngine.java:391)
   at org.apache.iotdb.db.engine.StorageEngine.loadNewTsFileForSync(StorageEngine.java:820)
   at org.apache.iotdb.db.sync.receiver.load.FileLoader.loadNewTsfile(FileLoader.java:143)
   ... 7 common frames omitted
   Caused by: org.apache.iotdb.db.exception.metadata.IllegalPathException: 10.20.12.142_0583441c495b416d95c9945631bc3eff is not a legal path
   at org.apache.iotdb.db.metadata.MTree.getStorageGroupNodeByPath(MTree.java:560)
   at org.apache.iotdb.db.metadata.MManager.getStorageGroupNodeByPath(MManager.java:1055)
   at org.apache.iotdb.db.engine.StorageEngine.getProcessorDirectly(StorageEngine.java:387)
   ... 9 common frames omitted
   2021-09-18 10:09:03,790 [pool-9-IoTDB-Load-TsFile-1] INFO o.a.i.d.s.r.l.FileLoader:177 - Sync loading process for 10.20.12.142_0583441c495b416d95c9945631bc3eff has finished.
   
   the reason is:
   - file path was generated by sender
   - file path was send to receiver
   - because of File.seperator is different between windows and unix, the file path was recognized to a file name
   - file path can not be set correct in receiver
   
   solution is:
   - reprogramming the transfer string
   - receiver will rebuild the file path by transfer string


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou commented on pull request #4025: [To rel/0.12][IOTDB-1731]Fix sync error between different os

Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #4025:
URL: https://github.com/apache/iotdb/pull/4025#issuecomment-927224154


   Test needed...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] yschengzi commented on pull request #4025: [To rel/0.12][IOTDB-1731]Fix sync error between different os

Posted by GitBox <gi...@apache.org>.
yschengzi commented on pull request #4025:
URL: https://github.com/apache/iotdb/pull/4025#issuecomment-935322537


   > Since it is reprogramming the transfer string, will it break if client and server are of the different versions, e.g. server is new version and the client is old? If so, just make sure the release note includes it for upgrading customer to be aware of it.
   
   i will be careful to this string, thanks for noticing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] yschengzi commented on pull request #4025: [To rel/0.12][IOTDB-1731]Fix sync error between different os

Posted by GitBox <gi...@apache.org>.
yschengzi commented on pull request #4025:
URL: https://github.com/apache/iotdb/pull/4025#issuecomment-935320719


   > Test needed...
   
   okk, there is some problem, i still work on it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] richard-yuan16 commented on pull request #4025: [To rel/0.12][IOTDB-1731]Fix sync error between different os

Posted by GitBox <gi...@apache.org>.
richard-yuan16 commented on pull request #4025:
URL: https://github.com/apache/iotdb/pull/4025#issuecomment-935102800


   Since it is reprogramming the transfer string, will it break if client and server are of the different versions, e.g. server is new version and the client is old? If so, just make sure the release note includes it for upgrading customer to be aware of it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou merged pull request #4025: [To rel/0.12][IOTDB-1731]Fix sync error between different os

Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #4025:
URL: https://github.com/apache/iotdb/pull/4025


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org