[jira] [Work logged] (HIVE-25415) auto-assign breaks on forks

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25415?focusedWorklogId=632656&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-632656 ]

ASF GitHub Bot logged work on HIVE-25415:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Aug/21 01:20
            Start Date: 03/Aug/21 01:20
    Worklog Time Spent: 10m 
      Work Description: jsoref opened a new pull request #2554:
URL: https://github.com/apache/hive/pull/2554


   Only run of org is apache
   
   Signed-off-by: Josh Soref <js...@users.noreply.github.com>
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   
   When I create a fork, and then create a PR in that fork, I get half of an error from the auto-assign workflow. Since it's really only configured to work in apache, it shouldn't run in my forks.
   
   ### Does this PR introduce _any_ user-facing change?
   Forks by devs will have fewer workflows run
   
   ### How was this patch tested?
   I set the default branch of my fork to this branch and then created a PR from another branch into the default branch. The auto assign workflow was skipped.
   
   I then added an additional commit to the default branch that changed `apache` to the name of the owner of my fork, and pushed that to the fork. And then I closed and reopened the PR, the auto-assign workflow was run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 632656)
    Remaining Estimate: 0h
            Time Spent: 10m

> auto-assign breaks on forks
> ---------------------------
>
>                 Key: HIVE-25415
>                 URL: https://issues.apache.org/jira/browse/HIVE-25415
>             Project: Hive
>          Issue Type: Bug
>          Components: Build Infrastructure
>            Reporter: Josh Soref
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code:java}
> Run shufo/auto-assign-reviewer-by-files@v1.1.1
> 5{
> 6  '**/*.thrift': [ 'kgyrtkirk', 'klcopp' ],
> 7  '**/*.g': [ 'kgyrtkirk' ],
> 8  '**/package.jdo': [ 'kgyrtkirk' ],
> 9  '**/schq/**': [ 'kgyrtkirk' ],
> 10  '**/*Scheduled*': [ 'kgyrtkirk' ],
> 11  '**/*[sS]ketches*': [ 'kgyrtkirk' ],
> 12  Jenkinsfile: [ 'kgyrtkirk' ],
> 13  '.github/**': [ 'kgyrtkirk' ],
> 14  '**/ddl/**': [ 'miklosgergely' ],
> 15  '**/ql/*@(Driver|Compiler|Executor)*.java': [ 'miklosgergely' ],
> 16  '**/schematool/**': [ 'miklosgergely' ],
> 17  '**/metatool/**': [ 'miklosgergely' ],
> 18  '**/tez/**/*.java': [ 'abstractdog' ],
> 19  '**/*Tez*java': [ 'abstractdog' ],
> 20  '**/*TopNKey*java': [ 'kasakrisz' ],
> 21  '**/*CardinalityPreserving*java': [ 'kasakrisz' ],
> 22  '**/*Llap*java': [ 'pgaref' ]
> 23}
> 24  beeline/src/test/org/apache/hive/beeline/schematool/TestHiveSchemaTool.java matches **/schematool/**
> 25finished!
> 26(node:1453) UnhandledPromiseRejectionWarning: HttpError: Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the check-spelling/hive repository.
> 27    at /home/runner/work/_actions/shufo/auto-assign-reviewer-by-files/v1.1.1/dist/index.js:1:301912
> 28    at processTicksAndRejections (internal/process/task_queues.js:93:5)
> 29    at async assignReviewers (/home/runner/work/_actions/shufo/auto-assign-reviewer-by-files/v1.1.1/dist/index.js:1:39056)
> 30(node:1453) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
> 31(node:1453) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
> Complete job0s {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)