You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/09 11:29:02 UTC

[GitHub] [superset] geido commented on pull request #18142: refactor: migrate ExploreCtasResultsButton component to FC & tsx

geido commented on pull request #18142:
URL: https://github.com/apache/superset/pull/18142#issuecomment-1033660389


   > > Hey @EugeneTorap this generally looks good. However, you have some linting issues to fix for the CI to pass. Let me know when you update this PR and I'll have a look at it. Thanks!
   > 
   > @geido Can you merge #17939 first and then I will update my PR
   
   Hello @EugeneTorap the #17939 is now merged. Please resolve your conflicting files and I'll be happy to do another review. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org