You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by an...@apache.org on 2003/07/26 18:40:08 UTC

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs XSLTProcess.java

antoine     2003/07/26 09:40:08

  Modified:    docs/manual/CoreTasks style.html
               src/main/org/apache/tools/ant/taskdefs XSLTProcess.java
  Log:
  XSLT/param@expression used as string instead of as expression as documented
  There were 2 options to fix the bugreport :
  - change the code
  - change the documentation
  I hope that the option to change the documentation is OK.
  Thanks for the bug report.
  PR: 21525
  
  Revision  Changes    Path
  1.28      +2 -2      ant/docs/manual/CoreTasks/style.html
  
  Index: style.html
  ===================================================================
  RCS file: /home/cvs/ant/docs/manual/CoreTasks/style.html,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- style.html	6 Feb 2003 14:20:38 -0000	1.27
  +++ style.html	26 Jul 2003 16:40:07 -0000	1.28
  @@ -186,8 +186,8 @@
     </tr>
     <tr>
       <td valign="top">expression</td>
  -    <td valign="top">XSL expression to be placed into the param. To pass a text
  -      value into the style sheet it needs to be escaped using single quotes.</td>
  +    <td valign="top">Text value to be placed into the param.<br/>
  +    Was originally intended to be an XSL expression.
       <td align="center" valign="top">Yes</td>
     </tr>
   </table>
  
  
  
  1.70      +8 -9      ant/src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java
  
  Index: XSLTProcess.java
  ===================================================================
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java,v
  retrieving revision 1.69
  retrieving revision 1.70
  diff -u -r1.69 -r1.70
  --- XSLTProcess.java	19 Jul 2003 11:20:13 -0000	1.69
  +++ XSLTProcess.java	26 Jul 2003 16:40:08 -0000	1.70
  @@ -609,7 +609,7 @@
           /** The parameter name */
           private String name = null;
   
  -        /** The parameter's XSL expression */
  +        /** The parameter's value */
           private String expression = null;
   
           /**
  @@ -622,10 +622,9 @@
           }
   
           /**
  -         * The XSL expression for the parameter value
  -         *
  -         * @param expression the XSL expression representing the
  -         *   parameter's value.
  +         * The parameter value
  +         * NOTE : was intended to be an XSL expression.
  +         * @param expression the parameter's value.
            */
           public void setExpression(String expression) {
               this.expression = expression;
  @@ -645,10 +644,10 @@
           }
   
           /**
  -         * Get the parameter expression
  +         * Get the parameter's value
            *
  -         * @return the parameter expression
  -         * @exception BuildException if the expression is not set.
  +         * @return the parameter value
  +         * @exception BuildException if the value is not set.
            */
           public String getExpression() throws BuildException {
               if (expression == null) {
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org