svn commit: r946598 - /trafficserver/traffic/trunk/proxy/mgmt2/cli2/ConfigCmd.cc

[mt...@apache.org]

Author: mturk
Date: Thu May 20 11:57:46 2010
New Revision: 946598

URL: http://svn.apache.org/viewvc?rev=946598&view=rev
Log:
Add few code comments. No functional change

Modified:
    trafficserver/traffic/trunk/proxy/mgmt2/cli2/ConfigCmd.cc

Modified: trafficserver/traffic/trunk/proxy/mgmt2/cli2/ConfigCmd.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/mgmt2/cli2/ConfigCmd.cc?rev=946598&r1=946597&r2=946598&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/mgmt2/cli2/ConfigCmd.cc (original)
+++ trafficserver/traffic/trunk/proxy/mgmt2/cli2/ConfigCmd.cc Thu May 20 11:57:46 2010
@@ -31,12 +31,15 @@
  ****************************************************************/
 
 #include "inktomi++.h"
-#include "../api2/include/INKMgmtAPI.h"
+#include "I_Layout.h"
+#include "INKMgmtAPI.h"
 #include "ShowCmd.h"
 #include "ConfigCmd.h"
 #include "createArgument.h"
 #include "CliMgmtUtils.h"
 #include "CliDisplay.h"
+// TODO: Remove all those system defines
+//       and protecect them via #ifdef HAVE_FOO_H
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
@@ -55,8 +58,8 @@
 #include <sys/stat.h>
 #include <fcntl.h>
 #include "cli_scriptpaths.h"
-#include <ConfigAPI.h>
-#include <SysAPI.h>
+#include "ConfigAPI.h"
+#include "SysAPI.h"
 
 
 int enable_restricted_commands = FALSE;
@@ -163,6 +166,8 @@ Cmd_Enable(ClientData clientData, Tcl_In
     Cli_Printf("Already Enabled\n");
     return CMD_OK;
   }
+  // TODO: Use here some proper getpass function
+  //       See APR's apr_password_get
   char passwd[256], ch = 'p';
   int i = 0;
   printf("Password:");
@@ -5755,6 +5760,11 @@ ConfigRadiusKeys(const char *record)
   INKString old_pwd_file = NULL;
   INKString dir_path = NULL;
 
+  // TODO: Use some proper getpass function here
+  //       depending on the system use either
+  //       getpass_r, getpassphrase or getpass
+  //       For platforms not having those
+  //       see apr_password_get
   Cli_Debug("ConfigRadiusKeys\n");
   Cli_Printf("\nEnter New Key:");
   fflush(stdout);
@@ -5795,7 +5805,8 @@ ConfigRadiusKeys(const char *record)
       Cli_Debug("[ConfigRadiusKeys] Failed to remove password file %s", old_pwd_file);
     xfree(old_pwd_file);
   }
-
+  // XXX: Is this an absolute or config relative path
+  //      Usage here smells like absolute.
   Cli_RecordGetString("proxy.config.auth.password_file_path", &dir_path);
   if (!dir_path) {
     Cli_Debug("[ConfigRadiusKeys] Failed to find the password file path.");