[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=448833&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448833 ]

ASF GitHub Bot logged work on ARTEMIS-2815:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jun/20 22:20
            Start Date: 20/Jun/20 22:20
    Worklog Time Spent: 10m 
      Work Description: Havret opened a new pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195


   I'm not sure if there more elegant way to do it in Java. Any hints would be greatly appreciated. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 448833)
    Remaining Estimate: 0h
            Time Spent: 10m

> Null pointer exception on queue update
> --------------------------------------
>
>                 Key: ARTEMIS-2815
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.13.0
>            Reporter: Krzysztof Porębski
>            Assignee: Krzysztof Porębski
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created without a filter. 
> The problem is with getQueueConfiguration method in QueueImpl class. There is no check if filter is null before getFilterString is invoked. 
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>    return new QueueConfiguration(name)
>       .setAddress(address)
>       .setId(id)
>       .setRoutingType(routingType)
>       .setFilterString(filter.getFilterString())
>       .setDurable(isDurable())
>       .setUser(user)
>       .setMaxConsumers(maxConsumers)
>       .setExclusive(exclusive)
>       .setGroupRebalance(groupRebalance)
>       .setGroupBuckets(groupBuckets)
>       .setGroupFirstKey(groupFirstKey)
>       .setLastValue(false)
>       .setLastValue(null)
>       .setNonDestructive(nonDestructive)
>       .setPurgeOnNoConsumers(purgeOnNoConsumers)
>       .setConsumersBeforeDispatch(consumersBeforeDispatch)
>       .setDelayBeforeDispatch(delayBeforeDispatch)
>       .setAutoDelete(autoDelete)
>       .setAutoDeleteDelay(autoDeleteDelay)
>       .setAutoDeleteMessageCount(autoDeleteMessageCount)
>       .setRingSize(ringSize)
>       .setConfigurationManaged(configurationManaged)
>       .setTemporary(temporary)
>       .setInternal(internalQueue)
>       .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
>       .setAutoCreated(autoCreated);
> }{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)