You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/21 17:40:57 UTC

[GitHub] [airflow] potiuk opened a new issue #13226: Use of SQLAInterface in custom models in Plugins

potiuk opened a new issue #13226:
URL: https://github.com/apache/airflow/issues/13226


   We might need to add to Airflow 2.0 upgrade documentation the need to use `CustomSQLAInterface` instead of `SQLAInterface`.
   
   If you want to define your own appbuilder models  you need to change the interface to a Custom one:
   
   Non-RBAC replace:
   ```
   from flask_appbuilder.models.sqla.interface import SQLAInterface
   datamodel = SQLAInterface(your_data_model)
   ```
   
   with RBAC (in 1.10):
   ```
   from airflow.www_rbac.utils import CustomSQLAInterface
   datamodel = CustomSQLAInterface(your_data_model)
   ```
   
   and in 2.0:
   
   ```
   from airflow.www.utils import CustomSQLAInterface
   datamodel = CustomSQLAInterface(your_data_model)
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #13226: Use of SQLAInterface in custom models in Plugins

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13226:
URL: https://github.com/apache/airflow/issues/13226#issuecomment-784537783


   Simply  import ogf the old SQLAInterface should tirgger a warning


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Dr-Denzy commented on issue #13226: Use of SQLAInterface in custom models in Plugins

Posted by GitBox <gi...@apache.org>.
Dr-Denzy commented on issue #13226:
URL: https://github.com/apache/airflow/issues/13226#issuecomment-783777475


   @potiuk I am writing an upgrade check for this issue. Could you provide more perspective on this issue so that I can write a suitable unit test for this upgrade check. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed issue #13226: Use of SQLAInterface in custom models in Plugins

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #13226:
URL: https://github.com/apache/airflow/issues/13226


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Dr-Denzy commented on issue #13226: Use of SQLAInterface in custom models in Plugins

Posted by GitBox <gi...@apache.org>.
Dr-Denzy commented on issue #13226:
URL: https://github.com/apache/airflow/issues/13226#issuecomment-763249989


   I will like to work on this issue. Please assign it to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on issue #13226: Use of SQLAInterface in custom models in Plugins

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13226:
URL: https://github.com/apache/airflow/issues/13226#issuecomment-786978477


   closed by https://github.com/apache/airflow/pull/14475


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org