You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Jayendra Parab <ja...@gmail.com> on 2021/05/10 07:04:30 UTC

Re: Review Request 73343: ATLAS-4279: Precommit is failing for DebugMetricsIT testcase

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73343/
-----------------------------------------------------------

(Updated May 10, 2021, 7:04 a.m.)


Review request for atlas, Ashutosh Mestry, Nixon Rodrigues, and Sarath Subramanian.


Summary (updated)
-----------------

ATLAS-4279: Precommit is failing for DebugMetricsIT testcase


Bugs: ATLAS-4279
    https://issues.apache.org/jira/browse/ATLAS-4279


Repository: atlas


Description
-------

DebugMetricsIT test case in introduced as part of commit for https://issues.apache.org/jira/browse/ATLAS-4106, is failing because the debug metrics are disabled by default and the test case expects the metrics to be enabled

So to fix this case, enabled the debug metrics in the webapp/src/test/resources/atlas-application.properties file.


Diffs
-----

  webapp/src/test/resources/atlas-application.properties adeade800 


Diff: https://reviews.apache.org/r/73343/diff/1/


Testing
-------

Ran the precommit with this fix and the test case has passed
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/537/


Thanks,

Jayendra Parab


Re: Review Request 73343: ATLAS-4279: Precommit is failing for DebugMetricsIT testcase

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73343/#review222960
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On May 10, 2021, 7:04 a.m., Jayendra Parab wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73343/
> -----------------------------------------------------------
> 
> (Updated May 10, 2021, 7:04 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4279
>     https://issues.apache.org/jira/browse/ATLAS-4279
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> DebugMetricsIT test case in introduced as part of commit for https://issues.apache.org/jira/browse/ATLAS-4106, is failing because the debug metrics are disabled by default and the test case expects the metrics to be enabled
> 
> So to fix this case, enabled the debug metrics in the webapp/src/test/resources/atlas-application.properties file.
> 
> 
> Diffs
> -----
> 
>   webapp/src/test/resources/atlas-application.properties adeade800 
> 
> 
> Diff: https://reviews.apache.org/r/73343/diff/1/
> 
> 
> Testing
> -------
> 
> Ran the precommit with this fix and the test case has passed
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/537/
> 
> 
> Thanks,
> 
> Jayendra Parab
> 
>