You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by thormanrd <gi...@git.apache.org> on 2016/06/27 20:37:24 UTC
[GitHub] flink pull request #2171: FLINK-3319 Added the or function to the CEP patter...
GitHub user thormanrd opened a pull request:
https://github.com/apache/flink/pull/2171
FLINK-3319 Added the or function to the CEP pattern
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thormanrd/flink FLINK-3319-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2171
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2171: FLINK-3319 Added the or function to the CEP patter...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2171: FLINK-3319 Added the or function to the CEP patter...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2171#discussion_r68719946
--- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java ---
@@ -424,87 +423,71 @@ public Integer select(Map<String, Integer> pattern) throws Exception {
env.execute();
}
+ /**
+ * Checks that a certain event sequence is recognized with an OR filter
+ * @throws Exception
+ */
@Test
- public void testTimeoutHandling() throws Exception {
--- End diff --
Why do you remove the `testTimeoutHandling` test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2171: FLINK-3319 Added the or function to the CEP pattern
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2171
Thanks for your work and patience @thormanrd. Changes look good. Will merge your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2171: FLINK-3319 Added the or function to the CEP pattern
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2171
Thanks for cleaning up the PR @thormanrd.
Could we also try to get rid of the merge commits? We actually always rebase in the Flink community and never merge branches. Furthermore, it seems as if you've transformed the `testTimeoutHandling` into another test case. This should be corrected.
What I meant with the `OrFilterFunctionTest` is an explicit test of the `OrFilterFunction` and not an implicit test where it is embedded into a CEP program.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---