You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/05/16 16:05:59 UTC
[GitHub] [trafficcontrol] moltzaum opened a new pull request #3580: Join
fields
moltzaum opened a new pull request #3580: Join fields
URL: https://github.com/apache/trafficcontrol/pull/3580
## What does this PR (Pull Request) do?
This PR should solve #2494 for the vast majority of reported cases, although there might be a few cases where the issue isn't fixed.
## Which Traffic Control components are affected by this PR?
- Traffic Ops
## What is the best way to verify this PR?
POST and PUT json objects mentioned in the issue. All of these should be fixed:
- POST, PUT /api/1.1/cachegroups
- parentCachegroupName, secondaryParentCachegroupName, typeName
- POST, PUT /api/1.1/asns
- cachegroup
- POST, PUT /api/1.3/deliveryservices
- cdnName, profileName, profileDescription
- POST, PUT /api/1.1/regions
- divisionName
- POST, PUT /api/1.1/phys_locations
- region
- POST, PUT /api/1.1/servers
- cachegroup, cdnName, physLocation, profile, profileDesc, status, type
- POST, PUT /api/1.1/tenants
At the moment I'm not sure if `profileparameters` will be fixed (so I'm going to check it out), and I don't know what other cases exist that aren't in the issue.
## If this is a bug fix, what versions of Traffic Ops are affected?
This bug has existed since each endpoint was originally written. That was awhile ago.
## The following criteria are ALL met by this PR
- [ ] This PR includes tests OR I have explained why tests are unnecessary
- [ ] This PR includes documentation OR I have explained why documentation is unnecessary
- [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services