You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/10 13:03:40 UTC

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #4597: Adding jsonExtractScalar function to extract field from json object

codecov-io edited a comment on pull request #4597:
URL: https://github.com/apache/incubator-pinot/pull/4597#issuecomment-529669548


   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4597?src=pr&el=h1) Report
   > Merging [#4597](https://codecov.io/gh/apache/incubator-pinot/pull/4597?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/2bda544f967e405a6aac20d2bb2abce430da9603&el=desc) will **increase** coverage by `0.42%`.
   > The diff coverage is `73.83%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4597/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/4597?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4597      +/-   ##
   ==========================================
   + Coverage   66.08%   66.50%   +0.42%     
   ==========================================
     Files        1072     1077       +5     
     Lines       54668    54978     +310     
     Branches     8152     8213      +61     
   ==========================================
   + Hits        36125    36565     +440     
   + Misses      15895    15717     -178     
   - Partials     2648     2696      +48     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4597?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/pinot/common/utils/SchemaUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvU2NoZW1hVXRpbHMuamF2YQ==) | `9.85% <0.00%> (ø)` | |
   | [...ger/realtime/Server2ControllerSegmentUploader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU2VydmVyMkNvbnRyb2xsZXJTZWdtZW50VXBsb2FkZXIuamF2YQ==) | `71.42% <ø> (ø)` | |
   | [...edicate/BaseDictionaryBasedPredicateEvaluator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL0Jhc2VEaWN0aW9uYXJ5QmFzZWRQcmVkaWNhdGVFdmFsdWF0b3IuamF2YQ==) | `54.16% <ø> (ø)` | |
   | [...predicate/BaseRawValueBasedPredicateEvaluator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL0Jhc2VSYXdWYWx1ZUJhc2VkUHJlZGljYXRlRXZhbHVhdG9yLmphdmE=) | `87.87% <ø> (ø)` | |
   | [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `59.37% <14.28%> (-6.73%)` | :arrow_down: |
   | [...not/core/data/recordtransformer/PinotDataType.java](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlY29yZHRyYW5zZm9ybWVyL1Bpbm90RGF0YVR5cGUuamF2YQ==) | `95.08% <33.33%> (-1.03%)` | :arrow_down: |
   | [...m/function/JsonExtractScalarTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vSnNvbkV4dHJhY3RTY2FsYXJUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `48.80% <48.80%> (ø)` | |
   | [...rg/apache/pinot/broker/routing/RoutingManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9Sb3V0aW5nTWFuYWdlci5qYXZh) | `80.91% <50.00%> (-0.24%)` | :arrow_down: |
   | [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `82.85% <50.00%> (-4.24%)` | :arrow_down: |
   | [...indexsegment/generator/SegmentGeneratorConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvZ2VuZXJhdG9yL1NlZ21lbnRHZW5lcmF0b3JDb25maWcuamF2YQ==) | `72.44% <50.00%> (+10.18%)` | :arrow_up: |
   | ... and [103 more](https://codecov.io/gh/apache/incubator-pinot/pull/4597/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4597?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4597?src=pr&el=footer). Last update [44b0a91...fa1bfdc](https://codecov.io/gh/apache/incubator-pinot/pull/4597?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org