You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Pavel Ozhdikhin (JIRA)" <ji...@apache.org> on 2007/05/15 16:13:16 UTC
[jira] Created: (HARMONY-3872) [drlvm][jit][opt] ArrayCopy
optimization does not insert pseudoThrow insts in loops
[drlvm][jit][opt] ArrayCopy optimization does not insert pseudoThrow insts in loops
-----------------------------------------------------------------------------------
Key: HARMONY-3872
URL: https://issues.apache.org/jira/browse/HARMONY-3872
Project: Harmony
Issue Type: Bug
Components: DRLVM
Environment: Linux/IPF
Reporter: Pavel Ozhdikhin
ArrayCopy optimization does not insert PseudoThrow instructions into copying loops it creates - as a result "rept" pass fails encountering a loop without any dispatch edge. All tests fails on IPF in JIT mode because of this bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3872) [drlvm][jit][opt] ArrayCopy
optimization does not insert pseudoThrow insts in loops
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov reassigned HARMONY-3872:
----------------------------------------
Assignee: Alexey Varlamov
> [drlvm][jit][opt] ArrayCopy optimization does not insert pseudoThrow insts in loops
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-3872
> URL: https://issues.apache.org/jira/browse/HARMONY-3872
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/IPF
> Reporter: Pavel Ozhdikhin
> Assigned To: Alexey Varlamov
> Attachments: arraycopy_fix.patch, HARMONY-3872.patch
>
>
> ArrayCopy optimization does not insert PseudoThrow instructions into copying loops it creates - as a result "rept" pass fails encountering a loop without any dispatch edge. All tests fails on IPF in JIT mode because of this bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3872) [drlvm][jit][opt] ArrayCopy
optimization does not insert pseudoThrow insts in loops
Posted by "Pavel Ozhdikhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Ozhdikhin updated HARMONY-3872:
-------------------------------------
Attachment: arraycopy_fix.patch
The preliminary patch is attached. It is not yet tested - I ran into strange build problems with APR.
> [drlvm][jit][opt] ArrayCopy optimization does not insert pseudoThrow insts in loops
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-3872
> URL: https://issues.apache.org/jira/browse/HARMONY-3872
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/IPF
> Reporter: Pavel Ozhdikhin
> Attachments: arraycopy_fix.patch
>
>
> ArrayCopy optimization does not insert PseudoThrow instructions into copying loops it creates - as a result "rept" pass fails encountering a loop without any dispatch edge. All tests fails on IPF in JIT mode because of this bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3872) [drlvm][jit][opt] ArrayCopy
optimization does not insert pseudoThrow insts in loops
Posted by "Pavel Ozhdikhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Ozhdikhin updated HARMONY-3872:
-------------------------------------
Patch Info: [Patch Available]
> [drlvm][jit][opt] ArrayCopy optimization does not insert pseudoThrow insts in loops
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-3872
> URL: https://issues.apache.org/jira/browse/HARMONY-3872
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/IPF
> Reporter: Pavel Ozhdikhin
> Attachments: arraycopy_fix.patch, HARMONY-3872.patch
>
>
> ArrayCopy optimization does not insert PseudoThrow instructions into copying loops it creates - as a result "rept" pass fails encountering a loop without any dispatch edge. All tests fails on IPF in JIT mode because of this bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3872) [drlvm][jit][opt] ArrayCopy
optimization does not insert pseudoThrow insts in loops
Posted by "Pavel Ozhdikhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Ozhdikhin updated HARMONY-3872:
-------------------------------------
Attachment: HARMONY-3872.patch
The updated patch is attached. It contains the following changes:
1. Includes the fix for the bug (actually the first patch).
2. Removes warning in IpfInstCodeSelector that PseudoThrow inst is not supported - it's actually not needed, the same instruction in IA32 CG does nothing.
3. gc.NPE test excluded in JIT mode - the needed functionality is not yet implemented in VM (HARMONY-3878)
Smoke test passes with this patch on Linux/IPF in jit/int modes. Kernel tests passed on interpreter but failed with assert when running in JIT mode:
[junit] Tests run: 15, Failures: 10, Errors: 0, Time elapsed: 22.797 sec
[junit] TEST java.lang.ClassAnnotationsTest FAILED
[junit] java: /export/pozhdikh/harmony/trunk/working_vm/vm/vmcore/src/class_support/String_Pool.cpp:199: String* String_Pool::lookup(const char*, long unsigned int, long long unsigned int): Assertion `key_stats->raw_hash == raw_hash' failed.
[junit] SIGABRT in VM code.
[junit] Tests FAILED
Current fix should not affect kernel tests. I propose to commit the patch and open a separate issue for the kernel test failure.
> [drlvm][jit][opt] ArrayCopy optimization does not insert pseudoThrow insts in loops
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-3872
> URL: https://issues.apache.org/jira/browse/HARMONY-3872
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/IPF
> Reporter: Pavel Ozhdikhin
> Attachments: arraycopy_fix.patch, HARMONY-3872.patch
>
>
> ArrayCopy optimization does not insert PseudoThrow instructions into copying loops it creates - as a result "rept" pass fails encountering a loop without any dispatch edge. All tests fails on IPF in JIT mode because of this bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3872) [drlvm][jit][opt] ArrayCopy
optimization does not insert pseudoThrow insts in loops
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov closed HARMONY-3872.
------------------------------------
Resolution: Fixed
Applied at r538895, thanks!
> [drlvm][jit][opt] ArrayCopy optimization does not insert pseudoThrow insts in loops
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-3872
> URL: https://issues.apache.org/jira/browse/HARMONY-3872
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/IPF
> Reporter: Pavel Ozhdikhin
> Assigned To: Alexey Varlamov
> Attachments: arraycopy_fix.patch, HARMONY-3872.patch
>
>
> ArrayCopy optimization does not insert PseudoThrow instructions into copying loops it creates - as a result "rept" pass fails encountering a loop without any dispatch edge. All tests fails on IPF in JIT mode because of this bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.