You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Glen Daniels <gd...@sonicsoftware.com> on 2004/12/09 16:27:10 UTC
[Axi2] Coding style
Hey folks:
As you noticed, I did a big commit after running IDEA's
code-cleaner-upper. This resolved a whole bunch of coding style issues
like whitespace at the end of lines, correct spacing for braces, etc.
So - is this OK with people? I'm figuring we want to use the standard
Java coding conventions as we have in Axis 1.1 (I'm certainly +1 to
that)....
If so, as we move on we should be careful to keep things clean, and we
can periodically run code cleanups like this every few months.
--Glen
Re: [Axi2] Coding style
Posted by Srinath Perera <he...@gmail.com>.
+ 1 :) :) :)
Thanks
Srinath
On Thu, 9 Dec 2004 21:38:18 +0600, Sanjiva Weerawarana
<sa...@opensource.lk> wrote:
> Most definitely, +100000 from me too!
>
> Sanjiva.
>
>
>
> ----- Original Message -----
> From: "Davanum Srinivas" <da...@gmail.com>
> To: <ax...@ws.apache.org>
> Sent: Thursday, December 09, 2004 9:28 PM
> Subject: Re: [Axi2] Coding style
>
> > +100000 from me.
> >
> > -- dims
> >
> >
> > On Thu, 9 Dec 2004 10:27:10 -0500, Glen Daniels
> > <gd...@sonicsoftware.com> wrote:
> > >
> > > Hey folks:
> > >
> > > As you noticed, I did a big commit after running IDEA's
> > > code-cleaner-upper. This resolved a whole bunch of coding style issues
> > > like whitespace at the end of lines, correct spacing for braces, etc.
> > >
> > > So - is this OK with people? I'm figuring we want to use the standard
> > > Java coding conventions as we have in Axis 1.1 (I'm certainly +1 to
> > > that)....
> > >
> > > If so, as we move on we should be careful to keep things clean, and we
> > > can periodically run code cleanups like this every few months.
> > >
> > > --Glen
> > >
> >
> >
> > --
> > Davanum Srinivas - http://webservices.apache.org/~dims/
> >
>
Re: [Axi2] Coding style
Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
Most definitely, +100000 from me too!
Sanjiva.
----- Original Message -----
From: "Davanum Srinivas" <da...@gmail.com>
To: <ax...@ws.apache.org>
Sent: Thursday, December 09, 2004 9:28 PM
Subject: Re: [Axi2] Coding style
> +100000 from me.
>
> -- dims
>
>
> On Thu, 9 Dec 2004 10:27:10 -0500, Glen Daniels
> <gd...@sonicsoftware.com> wrote:
> >
> > Hey folks:
> >
> > As you noticed, I did a big commit after running IDEA's
> > code-cleaner-upper. This resolved a whole bunch of coding style issues
> > like whitespace at the end of lines, correct spacing for braces, etc.
> >
> > So - is this OK with people? I'm figuring we want to use the standard
> > Java coding conventions as we have in Axis 1.1 (I'm certainly +1 to
> > that)....
> >
> > If so, as we move on we should be careful to keep things clean, and we
> > can periodically run code cleanups like this every few months.
> >
> > --Glen
> >
>
>
> --
> Davanum Srinivas - http://webservices.apache.org/~dims/
>
Re: [Axis2] Coding style - @author tags
Posted by Srinath Perera <he...@gmail.com>.
think we are decided .. I will wipe out the author tags.
Team edit your IDE prefernces so that author tags are not
automatically inserted.
Thanks
Srinath
On Mon, 13 Dec 2004 16:31:41 -0500, Aleksander Slominski
<as...@cs.indiana.edu> wrote:
> Glen Daniels wrote:
>
>
>
> > +1 to removing @author tags, by the way.
> >
> > I was a pretty strong proponent of being able to find the author of a
> > given class with this tag, but I've since been convinced that CVS/SVN
> > logs are good enough for that, and that there is a greater sense of
> > "team ownership" without them.
>
> +1 i agree for the same reasons.
>
> alek
>
> --
> The best way to predict the future is to invent it - Alan Kay
>
>
Re: [Axis2] Coding style - @author tags
Posted by Aleksander Slominski <as...@cs.indiana.edu>.
Glen Daniels wrote:
> +1 to removing @author tags, by the way.
>
> I was a pretty strong proponent of being able to find the author of a
> given class with this tag, but I've since been convinced that CVS/SVN
> logs are good enough for that, and that there is a greater sense of
> "team ownership" without them.
+1 i agree for the same reasons.
alek
--
The best way to predict the future is to invent it - Alan Kay
Re: [Axis2] Coding style - @author tags
Posted by Davanum Srinivas <da...@gmail.com>.
+1 from me as well.
-- dims
On Mon, 13 Dec 2004 15:41:08 -0500, Glen Daniels <gl...@thoughtcraft.com> wrote:
> +1 to removing @author tags, by the way.
>
> I was a pretty strong proponent of being able to find the author of a
> given class with this tag, but I've since been convinced that CVS/SVN
> logs are good enough for that, and that there is a greater sense of
> "team ownership" without them.
>
> --Glen
>
--
Davanum Srinivas - http://webservices.apache.org/~dims/
Re: [Axis2] Coding style - @author tags
Posted by Glen Daniels <gl...@thoughtcraft.com>.
+1 to removing @author tags, by the way.
I was a pretty strong proponent of being able to find the author of a
given class with this tag, but I've since been convinced that CVS/SVN
logs are good enough for that, and that there is a greater sense of
"team ownership" without them.
--Glen
Re: [Axis2] Coding style - @author tags
Posted by Srinath Perera <he...@gmail.com>.
+1 remove author tags
Thanks
Srinarh
On Thu, 9 Dec 2004 21:39:52 +0600, Sanjiva Weerawarana
<sa...@opensource.lk> wrote:
> Actually a related issue .. let's make a decision on whether to
> put @author tags in the codebase or not.
>
> I've noticed that some Apache projects have gone away from that
> to downright removing them. The idea, I believe, is that it
> encourages more community ownership of the code. I don't disagree.
>
> What does everyone think? We need to make a single decision and
> stick to it for consistency sake.
>
> Sanjiva.
>
> ----- Original Message -----
> From: "Davanum Srinivas" <da...@gmail.com>
> To: <ax...@ws.apache.org>
> Sent: Thursday, December 09, 2004 9:28 PM
> Subject: Re: [Axi2] Coding style
>
> > +100000 from me.
> >
> > -- dims
> >
> >
> > On Thu, 9 Dec 2004 10:27:10 -0500, Glen Daniels
> > <gd...@sonicsoftware.com> wrote:
> > >
> > > Hey folks:
> > >
> > > As you noticed, I did a big commit after running IDEA's
> > > code-cleaner-upper. This resolved a whole bunch of coding style issues
> > > like whitespace at the end of lines, correct spacing for braces, etc.
> > >
> > > So - is this OK with people? I'm figuring we want to use the standard
> > > Java coding conventions as we have in Axis 1.1 (I'm certainly +1 to
> > > that)....
> > >
> > > If so, as we move on we should be careful to keep things clean, and we
> > > can periodically run code cleanups like this every few months.
> > >
> > > --Glen
> > >
> >
> >
> > --
> > Davanum Srinivas - http://webservices.apache.org/~dims/
> >
>
Re: [Axis2] Coding style - @author tags
Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
Actually a related issue .. let's make a decision on whether to
put @author tags in the codebase or not.
I've noticed that some Apache projects have gone away from that
to downright removing them. The idea, I believe, is that it
encourages more community ownership of the code. I don't disagree.
What does everyone think? We need to make a single decision and
stick to it for consistency sake.
Sanjiva.
----- Original Message -----
From: "Davanum Srinivas" <da...@gmail.com>
To: <ax...@ws.apache.org>
Sent: Thursday, December 09, 2004 9:28 PM
Subject: Re: [Axi2] Coding style
> +100000 from me.
>
> -- dims
>
>
> On Thu, 9 Dec 2004 10:27:10 -0500, Glen Daniels
> <gd...@sonicsoftware.com> wrote:
> >
> > Hey folks:
> >
> > As you noticed, I did a big commit after running IDEA's
> > code-cleaner-upper. This resolved a whole bunch of coding style issues
> > like whitespace at the end of lines, correct spacing for braces, etc.
> >
> > So - is this OK with people? I'm figuring we want to use the standard
> > Java coding conventions as we have in Axis 1.1 (I'm certainly +1 to
> > that)....
> >
> > If so, as we move on we should be careful to keep things clean, and we
> > can periodically run code cleanups like this every few months.
> >
> > --Glen
> >
>
>
> --
> Davanum Srinivas - http://webservices.apache.org/~dims/
>
Re: [Axi2] Coding style
Posted by Davanum Srinivas <da...@gmail.com>.
+100000 from me.
-- dims
On Thu, 9 Dec 2004 10:27:10 -0500, Glen Daniels
<gd...@sonicsoftware.com> wrote:
>
> Hey folks:
>
> As you noticed, I did a big commit after running IDEA's
> code-cleaner-upper. This resolved a whole bunch of coding style issues
> like whitespace at the end of lines, correct spacing for braces, etc.
>
> So - is this OK with people? I'm figuring we want to use the standard
> Java coding conventions as we have in Axis 1.1 (I'm certainly +1 to
> that)....
>
> If so, as we move on we should be careful to keep things clean, and we
> can periodically run code cleanups like this every few months.
>
> --Glen
>
--
Davanum Srinivas - http://webservices.apache.org/~dims/
[axis2] Re: [Axi2] Coding style
Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
"Dominik Kacprzak" <do...@opentoolbox.com> writes:
>
> Another suggestion which will most likely get me flamed. How about
> changing the default width of text from the good old 80 characters
> to 120? A greater width makes wrapping less likely to occur. Just a
> thought:)
Wait, just a sec.
Ah, there's the flame thrower! ARGH!!!!! No way man, even on my
1400x1050 screen on my ThinkPad emacs still fits nicely at 80
columns wide.
Sanjiva.
Re: [Axi2] Coding style
Posted by Dominik Kacprzak <do...@opentoolbox.com>.
A quick note on coding styles. I used IDEA and JBuilder for the development and found out that JBuilder's "Java Standard code style" does not completely agree with IDEA's style. Since most editors allow you to tweak formatting, would it make sense to list all the options and their settings to make sure that folks use the same editor settings regardless of their favorite IDE?
Another suggestion which will most likely get me flamed. How about changing the default width of text from the good old 80 characters to 120? A greater width makes wrapping less likely to occur. Just a thought:)
- Dominik
On Thu, Dec 09, 2004 at 10:27:10AM -0500, Glen Daniels wrote:
>
> Hey folks:
>
> As you noticed, I did a big commit after running IDEA's
> code-cleaner-upper. This resolved a whole bunch of coding style issues
> like whitespace at the end of lines, correct spacing for braces, etc.
>
> So - is this OK with people? I'm figuring we want to use the standard
> Java coding conventions as we have in Axis 1.1 (I'm certainly +1 to
> that)....
>
> If so, as we move on we should be careful to keep things clean, and we
> can periodically run code cleanups like this every few months.
>
> --Glen
[Axis2] RE: [Axi2] Coding style
Posted by Glen Daniels <gl...@thoughtcraft.com>.
Whoops, that should have read [Axis2] and not [Axi2]....
--G
> -----Original Message-----
> From: Glen Daniels [mailto:gdaniels@sonicsoftware.com]
> Sent: Thursday, December 09, 2004 10:27 AM
> To: axis-dev@ws.apache.org
> Subject: [Axi2] Coding style
>
>
> Hey folks:
>
> As you noticed, I did a big commit after running IDEA's
> code-cleaner-upper. This resolved a whole bunch of coding
> style issues like whitespace at the end of lines, correct
> spacing for braces, etc.
>
> So - is this OK with people? I'm figuring we want to use the
> standard Java coding conventions as we have in Axis 1.1 (I'm
> certainly +1 to that)....
>
> If so, as we move on we should be careful to keep things
> clean, and we can periodically run code cleanups like this
> every few months.
>
> --Glen
>
>