You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/05 07:20:09 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2999: Support Predicate Pushdown for Parquet Lists (#2108)

tustvold commented on code in PR #2999:
URL: https://github.com/apache/arrow-rs/pull/2999#discussion_r1014596878


##########
parquet/src/column/reader/decoder.rs:
##########
@@ -264,9 +264,13 @@ impl<T: DataType> ColumnValueDecoder for ColumnValueDecoderImpl<T> {
     }
 }
 
+const SKIP_BUFFER_SIZE: usize = 1024;

Review Comment:
   It's a somewhat arbitrary number, it tries to strike a balance between small enough to not be overly wasteful but large enough that we don't end up repeatedly reading too few values



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org