[GitHub] [incubator-pinot] wuwenw commented on a change in pull request #7052: Add Query Options for GroupBy In-Segment Trim

[GitBox <gi...@apache.org>]

wuwenw commented on a change in pull request #7052:
URL: https://github.com/apache/incubator-pinot/pull/7052#discussion_r654124536



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/QueryOptions.java
##########
@@ -82,4 +98,24 @@ public static Long getTimeoutMs(Map<String, String> queryOptions) {
       return null;
     }
   }
+
+  @Nullable
+  public static Boolean getEnableSegmentTrim(Map<String, String> queryOptions) {
+    String enableSegmentTrim = queryOptions.get(Request.QueryOptionKey.SEGMENT_ENABLE_TRIM);
+    if (enableSegmentTrim != null) {
+      return Boolean.parseBoolean(enableSegmentTrim);
+    } else {
+      return null;
+    }
+  }

Review comment:
       Has to bring back null check to avoid nullpointerexception




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org