You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/12/15 08:24:14 UTC
svn commit: r1884445 -
/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormGenerateAppearancesTest.java
Author: tilman
Date: Tue Dec 15 08:24:14 2020
New Revision: 1884445
URL: http://svn.apache.org/viewvc?rev=1884445&view=rev
Log:
PDFBOX-4892: Sonar fix: use parameterized test; set to concurrent
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormGenerateAppearancesTest.java
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormGenerateAppearancesTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormGenerateAppearancesTest.java?rev=1884445&r1=1884444&r2=1884445&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormGenerateAppearancesTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormGenerateAppearancesTest.java Tue Dec 15 08:24:14 2020
@@ -20,60 +20,36 @@ package org.apache.pdfbox.pdmodel.intera
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import java.io.IOException;
+import java.io.InputStream;
import java.net.URL;
import org.apache.pdfbox.Loader;
import org.apache.pdfbox.pdmodel.PDDocument;
import org.apache.pdfbox.pdmodel.PDDocumentCatalog;
-import org.junit.jupiter.api.Test;
-
-class PDAcroFormGenerateAppearancesTest {
-
- /**
- * PDFBOX-5041 Missing font descriptor
- *
- * @throws IOException
- */
- @Test
- void test5041MissingFontDescriptor() throws IOException
- {
- String sourceUrl = "https://issues.apache.org/jira/secure/attachment/13016941/REDHAT-1301016-0.pdf";
-
- try (PDDocument testPdf = Loader.loadPDF(new URL(sourceUrl).openStream()))
- {
- PDDocumentCatalog catalog = testPdf.getDocumentCatalog();
-
- assertDoesNotThrow(() -> catalog.getAcroForm(), "Getting the AcroForm shall not throw an exception");
- }
- }
-
- /**
- * PDFBOX-4086 Character missing for encoding
- * @throws IOException
- */
- @Test
- void test4086CharNotEncodable() throws IOException
+import org.junit.jupiter.api.parallel.Execution;
+import org.junit.jupiter.api.parallel.ExecutionMode;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
+
+@Execution(ExecutionMode.CONCURRENT)
+class PDAcroFormGenerateAppearancesTest
+{
+ @ParameterizedTest
+ @ValueSource(strings =
{
- String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12908175/AML1.PDF";
+ // PDFBOX-5041 Missing font descriptor
+ "https://issues.apache.org/jira/secure/attachment/13016941/REDHAT-1301016-0.pdf",
- try (PDDocument testPdf = Loader.loadPDF(new URL(sourceUrl).openStream()))
- {
- PDDocumentCatalog catalog = testPdf.getDocumentCatalog();
+ // PDFBOX-4086 Character missing for encoding
+ "https://issues.apache.org/jira/secure/attachment/12908175/AML1.PDF",
- assertDoesNotThrow(() -> catalog.getAcroForm(), "Getting the AcroForm shall not throw an exception");
- }
- }
-
- /**
- * PDFBOX-5043 PaperMetaData
- * @throws IOException
- */
- @Test
- void test5043PaperMetaData() throws IOException
+ // PDFBOX-5043 PaperMetaData
+ "https://issues.apache.org/jira/secure/attachment/13016992/PDFBOX-3891-5.pdf"
+ })
+ void testGetAcroForm(String sourceUrl) throws IOException
{
- String sourceUrl = "https://issues.apache.org/jira/secure/attachment/13016992/PDFBOX-3891-5.pdf";
-
- try (PDDocument testPdf = Loader.loadPDF(new URL(sourceUrl).openStream()))
+ try (InputStream is = new URL(sourceUrl).openStream();
+ PDDocument testPdf = Loader.loadPDF(is))
{
PDDocumentCatalog catalog = testPdf.getDocumentCatalog();