You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/02 00:05:38 UTC

[GitHub] [superset] yousoph commented on a change in pull request #19112: fix: Dashboard import holding issue

yousoph commented on a change in pull request #19112:
URL: https://github.com/apache/superset/pull/19112#discussion_r840977128



##########
File path: superset-frontend/src/views/CRUD/hooks.ts
##########
@@ -448,7 +448,10 @@ export function useImportResource(
                 t(
                   'An error occurred while importing %s: %s',
                   resourceLabel,
-                  error.errors.map(payload => payload.message).join('\n'),
+                  [
+                    ...error.errors.map(payload => payload.message),
+                    'Please re-export your file and try importing again',

Review comment:
       > @kasiazjc , currently we are showing all db connection error using toast at the bottom-right corner. Do we need to change this? @evans ^^
   
   Agree that the bottom right toast is not the best place for error messages, but I think we can address that in a later effort instead of trying to do it in this fix. 
   (Also I think the tag is mean for @rusackas 😄 ) 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org